2020-11-24 06:14:00

by Ira Weiny

[permalink] [raw]
Subject: [PATCH 04/17] fs/afs: Convert to memzero_page()

From: Ira Weiny <[email protected]>

Convert the kmap()/memcpy()/kunmap() pattern to memzero_page().

Cc: David Howells <[email protected]>
Signed-off-by: Ira Weiny <[email protected]>
---
fs/afs/write.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/afs/write.c b/fs/afs/write.c
index 50371207f327..ed7419de0178 100644
--- a/fs/afs/write.c
+++ b/fs/afs/write.c
@@ -30,7 +30,6 @@ static int afs_fill_page(struct afs_vnode *vnode, struct key *key,
{
struct afs_read *req;
size_t p;
- void *data;
int ret;

_enter(",,%llu", (unsigned long long)pos);
@@ -38,9 +37,7 @@ static int afs_fill_page(struct afs_vnode *vnode, struct key *key,
if (pos >= vnode->vfs_inode.i_size) {
p = pos & ~PAGE_MASK;
ASSERTCMP(p + len, <=, PAGE_SIZE);
- data = kmap(page);
- memset(data + p, 0, len);
- kunmap(page);
+ memzero_page(page, p, len);
return 0;
}

--
2.28.0.rc0.12.gb6a658bd00c9


2020-12-04 10:23:59

by David Howells

[permalink] [raw]
Subject: Re: [PATCH 04/17] fs/afs: Convert to memzero_page()

[email protected] wrote:

> Convert the kmap()/memcpy()/kunmap() pattern to memzero_page().
>
> Cc: David Howells <[email protected]>
> Signed-off-by: Ira Weiny <[email protected]>

Acked-by: David Howells <[email protected]>