2021-07-30 14:56:07

by Fabio Aiuto

Subject: [PATCH 0/4] staging: rtl8723bs: little cleanup

This patch series does some little cleanup

Fabio Aiuto (4):
staging: rtl8723bs: fix camel case issue in struct wlan_bssid_ex
staging: rtl8723bs: remove unnecessary parentheses
staging: rtl8723bs: align condition to match open parentheses
staging: rtl8723bs: put condition parentheses at the end of a line

drivers/staging/rtl8723bs/core/rtw_mlme.c | 13 ++++++-------
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 ++++----
drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 12 ++++++------
6 files changed, 19 insertions(+), 20 deletions(-)

--
2.20.1

2021-07-30 14:56:54

by Fabio Aiuto

Subject: [PATCH 2/4] staging: rtl8723bs: remove unnecessary parentheses

fix the following checkpatch issues:

CHECK: Unnecessary parentheses around
'pnetwork->network.ie_length > target->ie_length'
33: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:604:
+ if ((pnetwork->network.ie_length >
target->ie_length) && (target->reserved[0] == 1))

CHECK: Unnecessary parentheses around
'target->reserved[0] == 1'
33: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:604:
+ if ((pnetwork->network.ie_length >
target->ie_length) && (target->reserved[0] == 1))

CHECK: Unnecessary parentheses around
'target->reserved[0] != 2'
39: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:608:
+ if ((target->reserved[0] != 2) &&
+ (target->reserved[0] >=
pnetwork->network.reserved[0])
) {

CHECK: Unnecessary parentheses around
'target->reserved[0] >= pnetwork->network.reserved[0]'
39: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:608:
+ if ((target->reserved[0] != 2) &&
+ (target->reserved[0]
>= pnetwork->network.reserved[0])
) {

Signed-off-by: Fabio Aiuto <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index 9f97986e8680..df599c2009b3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -601,12 +601,12 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t
pnetwork->last_scanned = jiffies;

/* target.reserved[0]== 1, means that scanned network is a bcn frame. */
- if ((pnetwork->network.ie_length > target->ie_length) && (target->reserved[0] == 1))
+ if (pnetwork->network.ie_length > target->ie_length && target->reserved[0] == 1)
update_ie = false;

/* probe resp(3) > beacon(1) > probe req(2) */
- if ((target->reserved[0] != 2) &&
- (target->reserved[0] >= pnetwork->network.reserved[0])
+ if (target->reserved[0] != 2 &&
+ target->reserved[0] >= pnetwork->network.reserved[0]
) {
update_ie = true;
} else {
--
2.20.1

2021-07-30 15:01:28

by Fabio Aiuto

Subject: [PATCH 3/4] staging: rtl8723bs: align condition to match open parentheses

fix following checkpatch issue:

CHECK: Alignment should match open parenthesis
54: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:609:
+ if (target->reserved[0] != 2 &&
+ target->reserved[0] >=
pnetwork->network.reserved[0]

Signed-off-by: Fabio Aiuto <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index df599c2009b3..d3d068babb5e 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -606,7 +606,7 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t

/* probe resp(3) > beacon(1) > probe req(2) */
if (target->reserved[0] != 2 &&
- target->reserved[0] >= pnetwork->network.reserved[0]
+ target->reserved[0] >= pnetwork->network.reserved[0]
) {
update_ie = true;
} else {
--
2.20.1

2021-07-30 15:01:29

by Fabio Aiuto

Subject: [PATCH 4/4] staging: rtl8723bs: put condition parentheses at the end of a line

put the closing parenthese at the end of a line

Signed-off-by: Fabio Aiuto <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index d3d068babb5e..5ed13bf765d2 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
@@ -606,8 +606,7 @@ void rtw_update_scanned_network(struct adapter *adapter, struct wlan_bssid_ex *t

/* probe resp(3) > beacon(1) > probe req(2) */
if (target->reserved[0] != 2 &&
- target->reserved[0] >= pnetwork->network.reserved[0]
- ) {
+ target->reserved[0] >= pnetwork->network.reserved[0]) {
update_ie = true;
} else {
update_ie = false;
--
2.20.1

2021-08-02 13:07:21

by Dan Carpenter

Subject: Re: [PATCH 2/4] staging: rtl8723bs: remove unnecessary parentheses

Please fold patches 2, 3 and 4 together. It counts as one patch because
it's "tidying up the condition".

regards,
dan carpenter

2021-08-02 13:31:29

by Fabio Aiuto

Subject: Re: [PATCH 2/4] staging: rtl8723bs: remove unnecessary parentheses

Hello Dan,

On Mon, Aug 02, 2021 at 04:05:51PM +0300, Dan Carpenter wrote:
>
> Please fold patches 2, 3 and 4 together. It counts as one patch because
> it's "tidying up the condition".
>
> regards,
> dan carpenter
>

ok I will next time I'll be submitting a similar cleaning,
they are already in staging-next...

thank you,

fabio