2022-11-09 13:50:36

by Yang Yang

[permalink] [raw]
Subject: [PATCH linux-next v2] ASoC: SOF: remove duplicated included sof-audio.h

From: Xu Panda <[email protected]>

The sof-audio.h is included more than once.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Xu Panda <[email protected]>
Signed-off-by: Yang Yang <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>

---
change for v2
- add maintainers and the alsa-devel mailing list in CC.
---

sound/soc/sof/amd/acp-common.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/sound/soc/sof/amd/acp-common.c b/sound/soc/sof/amd/acp-common.c
index 27b95187356e..348e70dfe2a5 100644
--- a/sound/soc/sof/amd/acp-common.c
+++ b/sound/soc/sof/amd/acp-common.c
@@ -13,7 +13,6 @@
#include "../sof-priv.h"
#include "../sof-audio.h"
#include "../ops.h"
-#include "../sof-audio.h"
#include "acp.h"
#include "acp-dsp-offset.h"

--
2.15.2


2022-11-09 14:50:46

by Péter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH linux-next v2] ASoC: SOF: remove duplicated included sof-audio.h



On 09/11/2022 15:30, [email protected] wrote:
> From: Xu Panda <[email protected]>
>
> The sof-audio.h is included more than once.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Xu Panda <[email protected]>
> Signed-off-by: Yang Yang <[email protected]>
> Reviewed-by: Pierre-Louis Bossart <[email protected]>

Reviewed-by: Peter Ujfalusi <[email protected]>

>
> ---
> change for v2
> - add maintainers and the alsa-devel mailing list in CC.
> ---
>
> sound/soc/sof/amd/acp-common.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sof/amd/acp-common.c b/sound/soc/sof/amd/acp-common.c
> index 27b95187356e..348e70dfe2a5 100644
> --- a/sound/soc/sof/amd/acp-common.c
> +++ b/sound/soc/sof/amd/acp-common.c
> @@ -13,7 +13,6 @@
> #include "../sof-priv.h"
> #include "../sof-audio.h"
> #include "../ops.h"
> -#include "../sof-audio.h"
> #include "acp.h"
> #include "acp-dsp-offset.h"
>

--
Péter

2022-11-10 18:39:12

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: SOF: remove duplicated included sof-audio.h

On Wed, Nov 09, 2022 at 09:30:54PM +0800, [email protected] wrote:
> From: Xu Panda <[email protected]>
>
> The sof-audio.h is included more than once.

This doesn't apply against current code, please check and resend:

Applying: ASoC: SOF: remove duplicated included sof-audio.h
error: corrupt patch at line 21
error: could not build fake ancestor
Patch failed at 0005 ASoC: SOF: remove duplicated included sof-audio.h

Attachments:
(No filename) (441.00 B)
 signature.asc (499.00 B)
 Download all attachments