2024-04-30 15:21:42

by Vitalii Bursov

Subject: [PATCH v4 2/3] sched/debug: dump domains' level

Knowing domain's level exactly can be useful when setting
relax_domain_level or cpuset.sched_relax_domain_level

Usage:
cat /debug/sched/domains/cpu0/domain1/level
to dump cpu0 domain1's level.

SDM macro is not used because sd->level is int and
it would hide the type mismatch between int and u32.

Signed-off-by: Vitalii Bursov <[email protected]>
Acked-by: Vincent Guittot <[email protected]>
Tested-by: Dietmar Eggemann <[email protected]>
---
kernel/sched/debug.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/sched/debug.c b/kernel/sched/debug.c
index 8d5d98a5834d..c1eb9a1afd13 100644
--- a/kernel/sched/debug.c
+++ b/kernel/sched/debug.c
@@ -425,6 +425,7 @@ static void register_sd(struct sched_domain *sd, struct dentry *parent)

debugfs_create_file("flags", 0444, parent, &sd->flags, &sd_flags_fops);
debugfs_create_file("groups_flags", 0444, parent, &sd->groups->flags, &sd_flags_fops);
+ debugfs_create_u32("level", 0444, parent, (u32 *)&sd->level);
}

void update_sched_domain_debugfs(void)
--
2.20.1

2024-05-02 16:01:46

by Valentin Schneider

Subject: Re: [PATCH v4 2/3] sched/debug: dump domains' level

On 30/04/24 18:05, Vitalii Bursov wrote:
> Knowing domain's level exactly can be useful when setting
> relax_domain_level or cpuset.sched_relax_domain_level
>
> Usage:
> cat /debug/sched/domains/cpu0/domain1/level
> to dump cpu0 domain1's level.
>
> SDM macro is not used because sd->level is int and
> it would hide the type mismatch between int and u32.
>
> Signed-off-by: Vitalii Bursov <[email protected]>
> Acked-by: Vincent Guittot <[email protected]>
> Tested-by: Dietmar Eggemann <[email protected]>

Reviewed-by: Valentin Schneider <[email protected]>