2017-11-07 21:29:41

by Baoquan He

[permalink] [raw]
Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation

PING!

On 10/28/17 at 09:34am, Baoquan He wrote:
> Use tabs (not spaces) for indentation.
>
> Signed-off-by: Baoquan He <[email protected]>
> ---
> include/acpi/actbl1.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> index 6b8714a428b6..d8a4fc066abe 100644
> --- a/include/acpi/actbl1.h
> +++ b/include/acpi/actbl1.h
> @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> u16 reserved; /* Reserved, must be zero */
> u64 base_address;
> u64 length;
> - u32 reserved1;
> + u32 reserved1;
> u32 flags;
> - u64 reserved2; /* Reserved, must be zero */
> + u64 reserved2; /* Reserved, must be zero */
> };
>
> /* Flags */
> --
> 2.5.5
>

From 1583420487538272267@xxx Tue Nov 07 15:10:51 +0000 2017
X-GM-THRID: 1582463214376446658
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread


2017-11-07 15:10:51

by Moore, Robert

[permalink] [raw]
Subject: RE: [PATCH] ACPICA: Clean up whitespace of indentation

Anything like this probably happens during the conversion of ACPICA code to Linux-style code. This conversion happens after every release (monthly) of ACPICA.

Specifically indent/lindent seems to do things like this, if I remember correctly.


> -----Original Message-----
> From: Baoquan He [mailto:[email protected]]
> Sent: Tuesday, November 7, 2017 2:43 AM
> To: [email protected]; [email protected]
> Cc: [email protected]; [email protected]; Moore, Robert
> <[email protected]>; Zheng, Lv <[email protected]>
> Subject: Re: [PATCH] ACPICA: Clean up whitespace of indentation
>
> PING!
>
> On 10/28/17 at 09:34am, Baoquan He wrote:
> > Use tabs (not spaces) for indentation.
> >
> > Signed-off-by: Baoquan He <[email protected]>
> > ---
> > include/acpi/actbl1.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h index
> > 6b8714a428b6..d8a4fc066abe 100644
> > --- a/include/acpi/actbl1.h
> > +++ b/include/acpi/actbl1.h
> > @@ -1438,9 +1438,9 @@ struct acpi_srat_mem_affinity {
> > u16 reserved; /* Reserved, must be zero */
> > u64 base_address;
> > u64 length;
> > - u32 reserved1;
> > + u32 reserved1;
> > u32 flags;
> > - u64 reserved2; /* Reserved, must be zero */
> > + u64 reserved2; /* Reserved, must be zero */
> > };
> >
> > /* Flags */
> > --
> > 2.5.5
> >

From 1582463214376446658@xxx Sat Oct 28 01:35:24 +0000 2017
X-GM-THRID: 1582463214376446658
X-Gmail-Labels: Inbox,Category Forums