2016-04-25 16:08:48

by J.D. Schroeder

Subject: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx

From: Jim Lodes <[email protected]>

The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
input/output status that had already been set by the
davinci_mcasp_set_sysclk function. This commit removes clearing
of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Signed-off-by: Jim Lodes <[email protected]>
Signed-off-by: J.D. Schroeder <[email protected]>
---
sound/soc/davinci/davinci-mcasp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index e132498..a1197ad 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);

mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
- ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
+ ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
mcasp->bclk_master = 0;
break;
default:
--
1.9.1

2016-04-29 13:20:32

by Peter Ujfalusi

Subject: Re: [PATCH] ASoC: davinci-mcasp: Fix overwriting of ahclkx

On 04/25/2016 07:08 PM, J.D. Schroeder wrote:
> From: Jim Lodes <[email protected]>
>
> The mcasp davinci_mcasp_set_dai_fmt function was overriding ahclkx
> input/output status that had already been set by the
> davinci_mcasp_set_sysclk function. This commit removes clearing
> of the ahclkx input/output status from davinci_mcasp_set_dai_fmt.

Acked-by: Peter Ujfalusi <[email protected]>

>
> Signed-off-by: Jim Lodes <[email protected]>
> Signed-off-by: J.D. Schroeder <[email protected]>
> ---
> sound/soc/davinci/davinci-mcasp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index e132498..a1197ad 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -489,7 +489,7 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
> mcasp_clr_bits(mcasp, DAVINCI_MCASP_RXFMCTL_REG, AFSRE);
>
> mcasp_clr_bits(mcasp, DAVINCI_MCASP_PDIR_REG,
> - ACLKX | AHCLKX | AFSX | ACLKR | AHCLKR | AFSR);
> + ACLKX | AFSX | ACLKR | AHCLKR | AFSR);
> mcasp->bclk_master = 0;
> break;
> default:
>


--
P?ter