2022-08-01 05:30:12

by Charan Teja Kalla

Subject: [PATCH] mm/page_ext: remove unused variable in offline_page_ext

Remove unused variable 'nid' in offline_page_ext(). This is not used
since the page_ext code inception.

Signed-off-by: Charan Teja Kalla <[email protected]>
---
mm/page_ext.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_ext.c b/mm/page_ext.c
index 3dc715d..e22a928 100644
--- a/mm/page_ext.c
+++ b/mm/page_ext.c
@@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
}

static int __meminit offline_page_ext(unsigned long start_pfn,
- unsigned long nr_pages, int nid)
+ unsigned long nr_pages)
{
unsigned long start, end, pfn;

@@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self,
break;
case MEM_OFFLINE:
offline_page_ext(mn->start_pfn,
- mn->nr_pages, mn->status_change_nid);
+ mn->nr_pages);
break;
case MEM_CANCEL_ONLINE:
offline_page_ext(mn->start_pfn,
- mn->nr_pages, mn->status_change_nid);
+ mn->nr_pages);
break;
case MEM_GOING_OFFLINE:
break;
--
2.7.4

2022-08-01 05:37:35

by Pavan Kondeti

Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext

On Mon, Aug 01, 2022 at 10:36:37AM +0530, Charan Teja Kalla wrote:
> Remove unused variable 'nid' in offline_page_ext(). This is not used
> since the page_ext code inception.
>

Just to be clear, should we say "drop nid argument from offline_page_exit"?
With this change the symmetry between "online_page_exit" and "offline_page_exit"
is lost. But that is not a valid point to keep an unused argument.

> Signed-off-by: Charan Teja Kalla <[email protected]>
> ---
> mm/page_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 3dc715d..e22a928 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
> }
>
> static int __meminit offline_page_ext(unsigned long start_pfn,
> - unsigned long nr_pages, int nid)
> + unsigned long nr_pages)
> {
> unsigned long start, end, pfn;
>
> @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self,
> break;
> case MEM_OFFLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_CANCEL_ONLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_GOING_OFFLINE:
> break;

Looks good to me.

Thanks,
Pavan

2022-08-01 08:48:55

by Michal Hocko

Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext

On Mon 01-08-22 10:36:37, Charan Teja Kalla wrote:
> Remove unused variable 'nid' in offline_page_ext(). This is not used
> since the page_ext code inception.
>
> Signed-off-by: Charan Teja Kalla <[email protected]>

Acked-by: Michal Hocko <[email protected]>
Thanks

> ---
> mm/page_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 3dc715d..e22a928 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
> }
>
> static int __meminit offline_page_ext(unsigned long start_pfn,
> - unsigned long nr_pages, int nid)
> + unsigned long nr_pages)
> {
> unsigned long start, end, pfn;
>
> @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self,
> break;
> case MEM_OFFLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_CANCEL_ONLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_GOING_OFFLINE:
> break;
> --
> 2.7.4

--
Michal Hocko
SUSE Labs

2022-08-01 09:16:35

by Anshuman Khandual

Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext

On 8/1/22 10:36, Charan Teja Kalla wrote:
> Remove unused variable 'nid' in offline_page_ext(). This is not used
> since the page_ext code inception.
>
> Signed-off-by: Charan Teja Kalla <[email protected]>

LGTM

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> mm/page_ext.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/mm/page_ext.c b/mm/page_ext.c
> index 3dc715d..e22a928 100644
> --- a/mm/page_ext.c
> +++ b/mm/page_ext.c
> @@ -336,7 +336,7 @@ static int __meminit online_page_ext(unsigned long start_pfn,
> }
>
> static int __meminit offline_page_ext(unsigned long start_pfn,
> - unsigned long nr_pages, int nid)
> + unsigned long nr_pages)
> {
> unsigned long start, end, pfn;
>
> @@ -362,11 +362,11 @@ static int __meminit page_ext_callback(struct notifier_block *self,
> break;
> case MEM_OFFLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_CANCEL_ONLINE:
> offline_page_ext(mn->start_pfn,
> - mn->nr_pages, mn->status_change_nid);
> + mn->nr_pages);
> break;
> case MEM_GOING_OFFLINE:
> break;

2022-08-01 12:39:52

by Charan Teja Kalla

Subject: Re: [PATCH] mm/page_ext: remove unused variable in offline_page_ext

Thanks Pavan for the comments!!

On 8/1/2022 10:58 AM, Pavan Kondeti wrote:
> On Mon, Aug 01, 2022 at 10:36:37AM +0530, Charan Teja Kalla wrote:
>> Remove unused variable 'nid' in offline_page_ext(). This is not used
>> since the page_ext code inception.
>>
> Just to be clear, should we say "drop nid argument from offline_page_exit"?
IIUC, drop is something we use if it ever considered to use earlier.
Remove is when we are completely getting rid of it.

Anyway, since it is just terminology and there are already some tags on
this change, I will let Andrew to take the decision and if he decides,
will give V2 with changing the commit message and collect all the tags.

Thanks,
Charan