2009-06-03 00:04:43

by Geunsik Lim

[permalink] [raw]
Subject: [PATCH] Fix the meaning of EDAC abbreviation



Dear Jiri Kosina,

This is trivial patch about meaning of EDAC in the driver/edac/Kconfig file.
* Screenshot after patch :
http://blogfiles16.naver.net/data42/2009/6/3/31/edac-before-after-invain.png


Thanks,


Subject: [PATCH] Fix the meaning of EDAC abbreviation

Fix the meaning of EDAC(Error Detection And Correction) correctly.
- http://bluesmoke.sourceforge.net

Signed-off-by: GeunSik Lim <[email protected]>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 956982f..2a81915 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -5,7 +5,7 @@
#

menuconfig EDAC
- bool "EDAC - error detection and reporting"
+ bool "EDAC - Error Detection And Correction"
depends on HAS_IOMEM
depends on X86 || PPC
help
--
1.6.3.1



-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***"
in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail :1) [email protected]
2) [email protected] , [email protected]
HomePage: http://blog.naver.com/invain/
-----------------------------------------------


2009-06-03 07:47:54

by Alan

[permalink] [raw]
Subject: Re: [PATCH] Fix the meaning of EDAC abbreviation

> Fix the meaning of EDAC(Error Detection And Correction) correctly.
> - http://bluesmoke.sourceforge.net
>
> Signed-off-by: GeunSik Lim <[email protected]>
> ---
> drivers/edac/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 956982f..2a81915 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -5,7 +5,7 @@
> #
>
> menuconfig EDAC
> - bool "EDAC - error detection and reporting"
> + bool "EDAC - Error Detection And Correction"

The code started off as one thing and acquired its name but a primary
function of it now is indeed reporting rather than just correction. The
name has stuck but the functionality doesn't quite match - so the
existing menuconfig entry is actually more helpful.

2009-06-03 08:34:51

by Geunsik Lim

[permalink] [raw]
Subject: Re: [PATCH] Fix the meaning of EDAC abbreviation

On Wed, Jun 3, 2009 at 4:42 PM, Alan Cox <[email protected]> wrote:
>> Fix the meaning of EDAC(Error Detection And Correction) correctly.
>>  - http://bluesmoke.sourceforge.net
>>
>>         Signed-off-by: GeunSik Lim <[email protected]>
>> ---
>>  drivers/edac/Kconfig |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
>> index 956982f..2a81915 100644
>> --- a/drivers/edac/Kconfig
>> +++ b/drivers/edac/Kconfig
>> @@ -5,7 +5,7 @@
>>  #
>>
>>  menuconfig EDAC
>> -     bool "EDAC - error detection and reporting"
>> +     bool "EDAC - Error Detection And Correction"
>
> The code started off as one thing and acquired its name but a primary
> function of it now is indeed reporting rather than just correction. The
Thank you for explanation and advice about EDAC meaning.

> name has stuck but the functionality doesn't quite match - so the
> existing menuconfig entry is actually more helpful.
Um.
How about we change contents with "EDAC (Error Detection And
Correction) reporting" to understand EDAC abbreviation normally?
This is Just my thinking.

Thks,


--
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: [email protected]
[email protected] , [email protected]

2009-06-03 10:20:24

by Geunsik Lim

[permalink] [raw]
Subject: [PATCH V2] Fix the meaning of EDAC abbreviation




Dear Jiri Kosina,

This is trivial patch.
I updated description about EDAC in the driver/edac/Kconfig.
thanks to Alan Cox. Please, merge this patch.

* Changelogs - V1
- Modify original word of EDAC abbreviation.
( http://patchwork.kernel.org/patch/27592/ )



Thanks,


Subject: [PATCH V2] Fix the meaning of EDAC abbreviation

Fix the meaning of EDAC(Error Detection And Correction) correctly.
- http://bluesmoke.sourceforge.net

Signed-off-by: GeunSik Lim <[email protected]>
Reviewed-by : Alan Cox <[email protected]>
---
drivers/edac/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 956982f..2a81915 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -5,7 +5,7 @@
#

menuconfig EDAC
- bool "EDAC - error detection and reporting"
+ bool "EDAC(Error Detection And Correction) reporting"
depends on HAS_IOMEM
depends on X86 || PPC
help
--
1.6.3.1


-----------------------------------------------
To unsubscribe from this list: send the line "unsubscribe linux-***"
in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

GeunSik Lim ( Samsung Electronics )
e-Mail :1) [email protected]
2) [email protected] , [email protected]
HomePage: http://blog.naver.com/invain/
-----------------------------------------------

2009-06-03 14:46:33

by Doug Thompson

[permalink] [raw]
Subject: Re: [PATCH] Fix the meaning of EDAC abbreviation


--- On Tue, 6/2/09, GeunSik Lim <[email protected]> wrote:

> From: GeunSik Lim <[email protected]>
> Subject: [PATCH] Fix the meaning of EDAC abbreviation
> To: "Jiri Kosina" <[email protected]>
> Cc: "linux-kernel" <[email protected]>, [email protected]
> Date: Tuesday, June 2, 2009, 6:04 PM
>
>
> Dear Jiri Kosina,
>
> This is trivial patch about meaning of EDAC in the
> driver/edac/Kconfig file.
> * Screenshot after patch :
> ???http://blogfiles16.naver.net/data42/2009/6/3/31/edac-before-after-invain.png
>
>
> Thanks,
>
>
> Subject: [PATCH] Fix the meaning of EDAC abbreviation
>
> Fix the meaning of EDAC(Error Detection And Correction)
> correctly.
> - http://bluesmoke.sourceforge.net
>
> ? ? ? ? Signed-off-by: GeunSik Lim
> <[email protected]>
> ---
> drivers/edac/Kconfig |? ? 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 956982f..2a81915 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -5,7 +5,7 @@
> #
>
> menuconfig EDAC
> -??? bool "EDAC - error detection and
> reporting"
> +??? bool "EDAC - Error Detection And
> Correction"
> ??? depends on HAS_IOMEM
> ??? depends on X86 || PPC
> ??? help
> --
> 1.6.3.1


Good catch. All these years and I didn't see it. Always need more eyes


Acked-by: Doug Thompson <[email protected]>

2009-06-03 14:51:42

by Doug Thompson

[permalink] [raw]
Subject: Re: [PATCH] Fix the meaning of EDAC abbreviation


--- On Wed, 6/3/09, Alan Cox <[email protected]> wrote:

> From: Alan Cox <[email protected]>
> Subject: Re: [PATCH] Fix the meaning of EDAC abbreviation
> To: [email protected]
> Cc: "Jiri Kosina" <[email protected]>, "linux-kernel" <[email protected]>, [email protected]
> Date: Wednesday, June 3, 2009, 1:42 AM
> > Fix the meaning of EDAC(Error
> Detection And Correction) correctly.
> >? - http://bluesmoke.sourceforge.net
> >
> >? ? ? ???Signed-off-by:
> GeunSik Lim <[email protected]>
> > ---
> >? drivers/edac/Kconfig |? ? 2 +-
> >? 1 files changed, 1 insertions(+), 1
> deletions(-)
> >
> > diff --git a/drivers/edac/Kconfig
> b/drivers/edac/Kconfig
> > index 956982f..2a81915 100644
> > --- a/drivers/edac/Kconfig
> > +++ b/drivers/edac/Kconfig
> > @@ -5,7 +5,7 @@
> >? #
> >?
> >? menuconfig EDAC
> > -??? bool "EDAC - error detection and
> reporting"
> > +??? bool "EDAC - Error Detection And
> Correction"
>
> The code started off as one thing and acquired its name but
> a primary
> function of it now is indeed reporting rather than just
> correction. The
> name has stuck but the functionality doesn't quite match -
> so the
> existing menuconfig entry is actually more helpful.
>

Alan has been "connected" with "bluesmoke"/EDAC far longer than I have and probably a better overall history of it.

Yet the EDAC modules harvest the events generated by the Error Detection and Correction hardware and present it, via reporting and he points out. But in spite of just being the "reporters", the modules manage the "detectors" in a way and deal with most of the "EDAC" system

I like the new patch mod

doug t

2009-06-03 14:54:23

by Doug Thompson

[permalink] [raw]
Subject: Re: [PATCH V2] Fix the meaning of EDAC abbreviation


--- On Wed, 6/3/09, GeunSik Lim <[email protected]> wrote:

> From: GeunSik Lim <[email protected]>
> Subject: [PATCH V2] Fix the meaning of EDAC abbreviation
> To: "Jiri Kosina" <[email protected]>
> Cc: "linux-kernel" <[email protected]>, [email protected], "Alan Cox" <[email protected]>
> Date: Wednesday, June 3, 2009, 4:12 AM
>
>
>
> Dear Jiri Kosina,
>
> This is trivial patch.
> I updated description about EDAC in the
> driver/edac/Kconfig.
> thanks to Alan Cox.? Please, merge this patch.
>
> * Changelogs - V1
> ? ? - Modify original word of EDAC abbreviation.
> ? ? ???( http://patchwork.kernel.org/patch/27592/
> )
>
>
>
> Thanks,
>
>
> Subject: [PATCH V2] Fix the meaning of EDAC abbreviation
>
> Fix the meaning of EDAC(Error Detection And Correction)
> correctly.
> - http://bluesmoke.sourceforge.net
>
> ? ? ? ? Signed-off-by: GeunSik Lim
> <[email protected]>
> ? ? ? ? Reviewed-by? : Alan Cox
> <[email protected]>
> ---
> drivers/edac/Kconfig |? ? 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 956982f..2a81915 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -5,7 +5,7 @@
> #
>
> menuconfig EDAC
> -??? bool "EDAC - error detection and
> reporting"
> +??? bool "EDAC(Error Detection And
> Correction) reporting"
> ??? depends on HAS_IOMEM
> ??? depends on X86 || PPC
> ??? help
> --
> 1.6.3.1

Ok, even better. It covers both contexts

doug t

2009-06-03 21:51:58

by Geunsik Lim

[permalink] [raw]
Subject: Re: [PATCH V2] Fix the meaning of EDAC abbreviation

On Wed, Jun 3, 2009 at 11:54 PM, Doug Thompson <[email protected]> wrote:
>>  menuconfig EDAC
>> -    bool "EDAC - error detection and
>> reporting"
>> +    bool "EDAC(Error Detection And
>> Correction) reporting"
>>      depends on HAS_IOMEM
>>      depends on X86 || PPC
>>      help>
> Ok, even better. It covers both contexts
Thanks for your reply.




--
Regards,
GeunSik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: [email protected]
[email protected] , [email protected]