2023-09-13 19:24:10

by Bjorn Andersson

Subject: Re: [PATCH v8 3/6] nvmem: core: Add stub for nvmem_cell_read_u8

On Wed, Aug 30, 2023 at 04:26:51PM +0530, Komal Bajaj wrote:
> Add the stub nvmem_cell_read_u8() function for drivers running with
> CONFIG_NVMEM disabled.
>
> Signed-off-by: Komal Bajaj <[email protected]>

Srini, do you have any concerns with me taking this together with the
remaining patches through my tree?

Regards,
Bjorn

> ---
> include/linux/nvmem-consumer.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
> index 4523e4e83319..6ec4b9743e25 100644
> --- a/include/linux/nvmem-consumer.h
> +++ b/include/linux/nvmem-consumer.h
> @@ -127,6 +127,12 @@ static inline int nvmem_cell_write(struct nvmem_cell *cell,
> return -EOPNOTSUPP;
> }
>
> +static inline int nvmem_cell_read_u8(struct device *dev,
> + const char *cell_id, u8 *val)
> +{
> + return -EOPNOTSUPP;
> +}
> +
> static inline int nvmem_cell_read_u16(struct device *dev,
> const char *cell_id, u16 *val)
> {
> --
> 2.41.0
>

2023-09-20 10:33:48

by Srinivas Kandagatla

Subject: Re: [PATCH v8 3/6] nvmem: core: Add stub for nvmem_cell_read_u8

On 13/09/2023 21:27, Bjorn Andersson wrote:
> On Wed, Aug 30, 2023 at 04:26:51PM +0530, Komal Bajaj wrote:
>> Add the stub nvmem_cell_read_u8() function for drivers running with
>> CONFIG_NVMEM disabled.
>>
>> Signed-off-by: Komal Bajaj <[email protected]>
>
> Srini, do you have any concerns with me taking this together with the
> remaining patches through my tree?

It works for me.

Acked-by: Srinivas Kandagatla <[email protected]>


--srin
>
> Regards,
> Bjorn
>
>> ---
>> include/linux/nvmem-consumer.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/include/linux/nvmem-consumer.h b/include/linux/nvmem-consumer.h
>> index 4523e4e83319..6ec4b9743e25 100644
>> --- a/include/linux/nvmem-consumer.h
>> +++ b/include/linux/nvmem-consumer.h
>> @@ -127,6 +127,12 @@ static inline int nvmem_cell_write(struct nvmem_cell *cell,
>> return -EOPNOTSUPP;
>> }
>>
>> +static inline int nvmem_cell_read_u8(struct device *dev,
>> + const char *cell_id, u8 *val)
>> +{
>> + return -EOPNOTSUPP;
>> +}
>> +
>> static inline int nvmem_cell_read_u16(struct device *dev,
>> const char *cell_id, u16 *val)
>> {
>> --
>> 2.41.0
>>