2023-04-06 18:46:15

by Tom Rix

Subject: [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static

smatch reports
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
'dcn3_14_soc' was not declared. Should it be static?

This variable is only used in one file so should be static.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
index c52b76610bd2..44082f65de1f 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
@@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
.dcc_supported = true,
};

-struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
+static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
/*TODO: correct dispclk/dppclk voltage level determination*/
.clock_limits = {
{
--
2.27.0

2023-04-10 14:51:04

by Hamza Mahfooz

Subject: Re: [PATCH] drm/amd/display: set variable dcn3_14_soc storage-class-specifier to static

On 4/6/23 14:44, Tom Rix wrote:
> smatch reports
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn314/dcn314_fpu.c:100:37: warning: symbol
> 'dcn3_14_soc' was not declared. Should it be static?
>
> This variable is only used in one file so should be static.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied, thanks!

> ---
> drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> index c52b76610bd2..44082f65de1f 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn314/dcn314_fpu.c
> @@ -97,7 +97,7 @@ struct _vcs_dpi_ip_params_st dcn3_14_ip = {
> .dcc_supported = true,
> };
>
> -struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
> +static struct _vcs_dpi_soc_bounding_box_st dcn3_14_soc = {
> /*TODO: correct dispclk/dppclk voltage level determination*/
> .clock_limits = {
> {
--
Hamza