2020-02-02 11:02:27

by Michal Rostecki

Subject: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

"HAVE" prefix is already applied by default to feature macros and before
this change, the large INSN limit macro had the incorrect name with
double "HAVE".

Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
Signed-off-by: Michal Rostecki <[email protected]>
---
tools/bpf/bpftool/feature.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpftool/feature.c b/tools/bpf/bpftool/feature.c
index 446ba891f1e2..941873d778d8 100644
--- a/tools/bpf/bpftool/feature.c
+++ b/tools/bpf/bpftool/feature.c
@@ -580,7 +580,7 @@ probe_large_insn_limit(const char *define_prefix, __u32 ifindex)
res = bpf_probe_large_insn_limit(ifindex);
print_bool_feature("have_large_insn_limit",
"Large program size limit",
- "HAVE_LARGE_INSN_LIMIT",
+ "LARGE_INSN_LIMIT",
res, define_prefix);
}

--
2.16.4

2020-02-02 20:02:15

by Yonghong Song

Subject: Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

On 2/2/20 3:02 AM, Michal Rostecki wrote:
> "HAVE" prefix is already applied by default to feature macros and before
> this change, the large INSN limit macro had the incorrect name with
> double "HAVE".
>
> Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
> Signed-off-by: Michal Rostecki <[email protected]>

Acked-by: Yonghong Song <[email protected]>

2020-02-03 23:11:33

by Daniel Borkmann

Subject: Re: [PATCH bpf] bpftool: Remove redundant "HAVE" prefix from the large INSN limit check

On 2/2/20 12:02 PM, Michal Rostecki wrote:
> "HAVE" prefix is already applied by default to feature macros and before
> this change, the large INSN limit macro had the incorrect name with
> double "HAVE".
>
> Fixes: 2faef64aa6b3 ("bpftool: Add misc section and probe for large INSN limit")
> Signed-off-by: Michal Rostecki <[email protected]>

Applied, thanks!