2020-01-03 16:26:23

by Vikas Gupta

Subject: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context

Fix calling multiple tee_client_close_context in case of shm allocation
fails.

Fixes: 246880958ac9 (“firmware: broadcom: add OP-TEE based BNXT f/w manager”)
Signed-off-by: Vikas Gupta <[email protected]>
---
drivers/firmware/broadcom/tee_bnxt_fw.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c
index 5b7ef89..ed10da5 100644
--- a/drivers/firmware/broadcom/tee_bnxt_fw.c
+++ b/drivers/firmware/broadcom/tee_bnxt_fw.c
@@ -215,7 +215,6 @@ static int tee_bnxt_fw_probe(struct device *dev)
fw_shm_pool = tee_shm_alloc(pvt_data.ctx, MAX_SHM_MEM_SZ,
TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
if (IS_ERR(fw_shm_pool)) {
- tee_client_close_context(pvt_data.ctx);
dev_err(pvt_data.dev, "tee_shm_alloc failed\n");
err = PTR_ERR(fw_shm_pool);
goto out_sess;
--
2.7.4

2020-01-05 22:48:43

by David Miller

Subject: Re: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context

What does "INTERNAL" mean in these patch Subject lines?

2020-01-06 06:26:21

by Vikas Gupta

Subject: RE: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to tee_client_close_context

"INTERNAL" and version "v2" added accidently. Please ignore this. I`ll
send updated patch.

-----Original Message-----
From: David Miller [mailto:[email protected]]
Sent: Monday, January 06, 2020 4:18 AM
To: [email protected]
Cc: [email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected];
[email protected]; [email protected]
Subject: Re: [PATCH INTERNAL v2] firmware: tee_bnxt: Fix multiple call to
tee_client_close_context


What does "INTERNAL" mean in these patch Subject lines?