Mark Intel PCIe driver depends on MSI IRQ Domain to fix
the below warnings and respective build errors.
WARNING: unmet direct dependencies detected for PCIE_DW_HOST
Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
Selected by [y]:
- PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
Dilip Kota (1):
PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
--
2.11.0
Kernel compilation fails for i386 architecture as PCI_MSI_IRQ_DOMAIN
is not set.
Synopsys DesignWare framework depends on the PCI_MSI_IRQ_DOMAIN.
So mark the Intel PCIe controller driver dependency on PCI_MSI_IRQ_DOMAIN
as it uses the Synopsys DesignWare framework.
Reported-by: Randy Dunlap <[email protected]>
Signed-off-by: Dilip Kota <[email protected]>
---
drivers/pci/controller/dwc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index e580ae036d77..d8116ed7f3a4 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -212,6 +212,7 @@ config PCIE_ARTPEC6_EP
config PCIE_INTEL_GW
bool "Intel Gateway PCIe host controller support"
depends on OF && (X86 || COMPILE_TEST)
+ depends on PCI_MSI_IRQ_DOMAIN
select PCIE_DW_HOST
help
Say 'Y' here to enable PCIe Host controller support on Intel
--
2.11.0
[+Bjorn]
On Thu, Nov 28, 2019 at 04:31:12PM +0800, Dilip Kota wrote:
> Mark Intel PCIe driver depends on MSI IRQ Domain to fix
> the below warnings and respective build errors.
>
> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> Selected by [y]:
> - PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
I don't know yet if we fix it up or I drop the series, given how
late this is in the release cycle and very short time this code
has been in -next.
Lorenzo
On Thu, Nov 28, 2019 at 10:19:55AM +0000, Lorenzo Pieralisi wrote:
> [+Bjorn]
>
> On Thu, Nov 28, 2019 at 04:31:12PM +0800, Dilip Kota wrote:
> > Mark Intel PCIe driver depends on MSI IRQ Domain to fix
> > the below warnings and respective build errors.
> >
> > WARNING: unmet direct dependencies detected for PCIE_DW_HOST
> > Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> > Selected by [y]:
> > - PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
>
> I don't know yet if we fix it up or I drop the series, given how
> late this is in the release cycle and very short time this code
> has been in -next.
I think given the timing and the holiday we need to drop it for now.
On 11/28/19 12:31 AM, Dilip Kota wrote:
> Kernel compilation fails for i386 architecture as PCI_MSI_IRQ_DOMAIN
> is not set.
>
> Synopsys DesignWare framework depends on the PCI_MSI_IRQ_DOMAIN.
> So mark the Intel PCIe controller driver dependency on PCI_MSI_IRQ_DOMAIN
> as it uses the Synopsys DesignWare framework.
>
> Reported-by: Randy Dunlap <[email protected]>
> Signed-off-by: Dilip Kota <[email protected]>
Passes my previously failing kernel configs. Thanks.
Acked-by: Randy Dunlap <[email protected]> # build-tested
> ---
> drivers/pci/controller/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index e580ae036d77..d8116ed7f3a4 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -212,6 +212,7 @@ config PCIE_ARTPEC6_EP
> config PCIE_INTEL_GW
> bool "Intel Gateway PCIe host controller support"
> depends on OF && (X86 || COMPILE_TEST)
> + depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> help
> Say 'Y' here to enable PCIe Host controller support on Intel
>
--
~Randy
Reported-by: Randy Dunlap <[email protected]>
On Thu, Nov 28, 2019 at 04:31:12PM +0800, Dilip Kota wrote:
> Mark Intel PCIe driver depends on MSI IRQ Domain to fix
> the below warnings and respective build errors.
>
> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
> Selected by [y]:
> - PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
>
> Dilip Kota (1):
> PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain
>
> drivers/pci/controller/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Hi Dilip,
would you mind squashing this patch into the initial series and repost
it (rebase it against current mainline) straight away ? I will
rebase it to -rc1 and push it out next week (I am asking since then
I am afk for a month so I would like to get your code queued asap,
it is ready).
Thanks,
Lorenzo
On 12/6/2019 12:23 AM, Lorenzo Pieralisi wrote:
> On Thu, Nov 28, 2019 at 04:31:12PM +0800, Dilip Kota wrote:
>> Mark Intel PCIe driver depends on MSI IRQ Domain to fix
>> the below warnings and respective build errors.
>>
>> WARNING: unmet direct dependencies detected for PCIE_DW_HOST
>> Depends on [n]: PCI [=y] && PCI_MSI_IRQ_DOMAIN [=n]
>> Selected by [y]:
>> - PCIE_INTEL_GW [=y] && PCI [=y] && OF [=y] && (X86 [=y] || COMPILE_TEST [=n])
>>
>> Dilip Kota (1):
>> PCI: dwc: Kconfig: Mark intel PCIe driver depends on MSI IRQ Domain
>>
>> drivers/pci/controller/dwc/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
> Hi Dilip,
>
> would you mind squashing this patch into the initial series and repost
> it (rebase it against current mainline) straight away ? I will
> rebase it to -rc1 and push it out next week (I am asking since then
> I am afk for a month so I would like to get your code queued asap,
> it is ready).
Sure, i will do it.
Thanks for prioritizing.
Regards,
Dilip
>
> Thanks,
> Lorenzo