2023-09-14 07:11:30

by Andrew Lunn

Subject: Re: [RFC PATCH net-next 6/6] microchip: lan865x: add device-tree support for Microchip's LAN865X MACPHY

> + oa-chunk-size: true
> + oa-tx-cut-through: true
> + oa-rx-cut-through: true
> + oa-protected: true

Please split this up into properties all OA TC6 devices are expected
to use, and those specific to the LAN865x. Put the generic properties
into a .yaml file, which you then inherit into the device specific
yaml file.

Also, LAN865x specific properties should have a vendor prefix.

Andrew

2023-09-19 11:59:09

by Parthiban Veerasooran

Subject: Re: [RFC PATCH net-next 6/6] microchip: lan865x: add device-tree support for Microchip's LAN865X MACPHY

Hi Andrew,

On 14/09/23 7:37 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> + oa-chunk-size: true
>> + oa-tx-cut-through: true
>> + oa-rx-cut-through: true
>> + oa-protected: true
>
> Please split this up into properties all OA TC6 devices are expected
> to use, and those specific to the LAN865x. Put the generic properties
> into a .yaml file, which you then inherit into the device specific
> yaml file.
>
> Also, LAN865x specific properties should have a vendor prefix.
Sure, will do both.

Best Regards,
Parthiban V
>
> Andrew