2008-06-03 18:19:34

by Harvey Harrison

Subject: [PATCH 1/2] lib: export bitrev16

Bluetooth will be able to use this.

Signed-off-by: Harvey Harrison <[email protected]>
---
include/linux/bitrev.h | 1 +
lib/bitrev.c | 3 ++-
2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
index 05e540d..7ffe03f 100644
--- a/include/linux/bitrev.h
+++ b/include/linux/bitrev.h
@@ -10,6 +10,7 @@ static inline u8 bitrev8(u8 byte)
return byte_rev_table[byte];
}

+extern u16 bitrev16(u16 in);
extern u32 bitrev32(u32 in);

#endif /* _LINUX_BITREV_H */
diff --git a/lib/bitrev.c b/lib/bitrev.c
index 989aff7..3956203 100644
--- a/lib/bitrev.c
+++ b/lib/bitrev.c
@@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
};
EXPORT_SYMBOL_GPL(byte_rev_table);

-static __always_inline u16 bitrev16(u16 x)
+u16 bitrev16(u16 x)
{
return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
}
+EXPORT_SYMBOL(bitrev16);

/**
* bitrev32 - reverse the order of bits in a u32 value
--
1.5.6.rc0.336.ge5422

2008-06-04 06:44:29

by Marcel Holtmann

Subject: Re: [PATCH 1/2] lib: export bitrev16

Hi Harvey,

> Bluetooth will be able to use this.
>
> Signed-off-by: Harvey Harrison <[email protected]>

Acked-by: Marcel Holtmann <[email protected]>

Regards

Marcel

2008-06-04 15:04:48

by Akinobu Mita

Subject: Re: [PATCH 1/2] lib: export bitrev16

> --- a/lib/bitrev.c
> +++ b/lib/bitrev.c
> @@ -42,10 +42,11 @@ const u8 byte_rev_table[256] = {
> };
> EXPORT_SYMBOL_GPL(byte_rev_table);
>
> -static __always_inline u16 bitrev16(u16 x)
> +u16 bitrev16(u16 x)
> {
> return (bitrev8(x & 0xff) << 8) | bitrev8(x >> 8);
> }
> +EXPORT_SYMBOL(bitrev16);

How about just moving bitrev16() from lib/bitrev.c to include/linux/bitrev.h
with s/__always_inline/inline/ rather than making it export symbol?