2023-10-24 02:36:24

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: clk-si544: Simplify probe() and is_valid_frequency()

Quoting Biju Das (2023-09-09 08:54:18)
> The driver has an OF match table, still, it uses an ID lookup table for
> retrieving match data. Currently, the driver is working on the
> assumption that an I2C device registered via OF will always match a
> legacy I2C device ID. The correct approach is to have an OF device ID
> table using i2c_get_match_data() if the devices are registered via OF/ID.
>
> Unify the OF/ID table by using max_freq as match data instead of
> enum si544_speed_grade and replace the ID lookup table for
> the match data by i2c_get_match_data(). This allows to simplify both
> probe() and is_valid_frequency().
>
> Drop enum si544_speed_grade as there is no user.
>
> While at it, remove the trailing comma in the terminator entry for the OF
> table making code robust against (theoretical) misrebases or other similar
> things where the new entry goes _after_ the termination without the
> compiler noticing.
>
> Signed-off-by: Biju Das <[email protected]>
> ---

Applied to clk-next