2020-11-16 17:03:59

by Jerome Brunet

[permalink] [raw]
Subject: [PATCH] arm64: meson: select COMMON_CLK

This fix the recent removal of clock drivers selection.
While it is not necessary to select the clock drivers themselves, we need
to select a proper implementation of the clock API, which for the meson, is
CCF

Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers")
Signed-off-by: Jerome Brunet <[email protected]>
---

This fix is a side effect of this 0day report:
https://lore.kernel.org/r/[email protected]
It shows that we need to select an implementation of clk.h

arch/arm64/Kconfig.platforms | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 329e22c09cad..484e81f39db7 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -151,6 +151,7 @@ config ARCH_MEDIATEK

config ARCH_MESON
bool "Amlogic Platforms"
+ select COMMON_CLK
select PINCTRL
select PINCTRL_MESON
select MESON_IRQ_GPIO
--
2.28.0


2020-11-17 08:38:14

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: meson: select COMMON_CLK

On 16/11/2020 17:58, Jerome Brunet wrote:
> This fix the recent removal of clock drivers selection.
> While it is not necessary to select the clock drivers themselves, we need
> to select a proper implementation of the clock API, which for the meson, is
> CCF
>
> Fixes: ba66a25536dd ("arm64: meson: ship only the necessary clock controllers")
> Signed-off-by: Jerome Brunet <[email protected]>
> ---
>
> This fix is a side effect of this 0day report:
> https://lore.kernel.org/r/[email protected]
> It shows that we need to select an implementation of clk.h
>
> arch/arm64/Kconfig.platforms | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 329e22c09cad..484e81f39db7 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -151,6 +151,7 @@ config ARCH_MEDIATEK
>
> config ARCH_MESON
> bool "Amlogic Platforms"
> + select COMMON_CLK
> select PINCTRL
> select PINCTRL_MESON
> select MESON_IRQ_GPIO
>

Reviewed-by: Neil Armstrong <[email protected]>