2022-10-26 00:18:20

by Doug Anderson

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME

The sc7280-herobrine-villager derivative doesn't have NVME enabled so
we shouldn't mark the PCIe nodes as "okay" since they're just for
boards that have NVME.

Signed-off-by: Douglas Anderson <[email protected]>
---

.../arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
index 3dff610fb946..17553e0fd6fd 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager.dtsi
@@ -78,16 +78,6 @@ &mdss_edp_phy {
status = "okay";
};

-/* For nvme */
-&pcie1 {
- status = "okay";
-};
-
-/* For nvme */
-&pcie1_phy {
- status = "okay";
-};
-
&pwmleds {
status = "okay";
};
--
2.38.0.135.g90850a2211-goog



2022-10-26 15:12:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME

On 25/10/2022 19:52, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-10-26 20:42:37

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME

Quoting Douglas Anderson (2022-10-25 16:52:39)
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
> Signed-off-by: Douglas Anderson <[email protected]>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2022-11-08 02:06:03

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Villager doesn't have NVME

On Tue, 25 Oct 2022 16:52:39 -0700, Douglas Anderson wrote:
> The sc7280-herobrine-villager derivative doesn't have NVME enabled so
> we shouldn't mark the PCIe nodes as "okay" since they're just for
> boards that have NVME.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280: Villager doesn't have NVME
commit: bcfefc98c5781ee97f1b7a8063870830d9e42b30

Best regards,
--
Bjorn Andersson <[email protected]>