2017-12-14 05:35:01

by Bjorn Andersson

Subject: Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation

On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:
> + /* By name */
> + mem = rproc_find_carveout_by_name(rproc, rsc->name);
> + if (mem) {
> + /*
> + * Update resource table with registered carevout information
> + */
> + rsc->len = mem->len;

You should validate that len, da and pa are compatible.

> + rsc->da = mem->da;
> + rsc->pa = rproc_va_to_pa(mem->va);
> + /* no need to register as already match one for one */
> + return 0;
> + }

Regards,
Bjorn

2018-01-15 20:59:43

by Loic Pallardy

Subject: RE: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout by name for carveout allocation

> -----Original Message-----
> From: Bjorn Andersson [mailto:[email protected]]
> Sent: Thursday, December 14, 2017 6:35 AM
> To: Loic PALLARDY <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; Arnaud POULIQUEN <[email protected]>;
> [email protected]
> Subject: Re: [PATCH v2 14/16] remoteproc: look-up pre-registered carveout
> by name for carveout allocation
>
> On Thu 30 Nov 08:46 PST 2017, Loic Pallardy wrote:
> > + /* By name */
> > + mem = rproc_find_carveout_by_name(rproc, rsc->name);
> > + if (mem) {
> > + /*
> > + * Update resource table with registered carevout
> information
> > + */
> > + rsc->len = mem->len;
>
> You should validate that len, da and pa are compatible.
Yes you're right, complete definition must be checked

Regards,
Loic
>
> > + rsc->da = mem->da;
> > + rsc->pa = rproc_va_to_pa(mem->va);
> > + /* no need to register as already match one for one */
> > + return 0;
> > + }
>
> Regards,
> Bjorn