2023-07-18 21:04:59

by Eric Van Hensbergen

Subject: [PATCH v2 4/4] fs/9p: remove unnecessary invalidate_inode_pages2

There was an invalidate_inode_pages2
added to mmap that is unnecessary.

Signed-off-by: Eric Van Hensbergen <[email protected]>
---
fs/9p/vfs_file.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index bda3abd6646b8..3809f3a531499 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -506,7 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)

if (!(v9ses->cache & CACHE_WRITEBACK)) {
p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");
- invalidate_inode_pages2(filp->f_mapping);
return generic_file_readonly_mmap(filp, vma);
}


--
2.39.2

2023-07-19 13:40:58

by Christian Schoenebeck

Subject: Re: [PATCH v2 4/4] fs/9p: remove unnecessary invalidate_inode_pages2

On Tuesday, July 18, 2023 10:50:18 PM CEST Eric Van Hensbergen wrote:
> There was an invalidate_inode_pages2
> added to mmap that is unnecessary.
>
> Signed-off-by: Eric Van Hensbergen <[email protected]>
> ---

Reviewed-by: Christian Schoenebeck <[email protected]>

> fs/9p/vfs_file.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
> index bda3abd6646b8..3809f3a531499 100644
> --- a/fs/9p/vfs_file.c
> +++ b/fs/9p/vfs_file.c
> @@ -506,7 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma)
>
> if (!(v9ses->cache & CACHE_WRITEBACK)) {
> p9_debug(P9_DEBUG_CACHE, "(no mmap mode)");
> - invalidate_inode_pages2(filp->f_mapping);
> return generic_file_readonly_mmap(filp, vma);
> }
>
>
>