2019-01-21 08:04:54

by Baolin Wang

Subject: [PATCH] gpio: sprd: Remove unused irq trigger setting

The Spreadtrum PMIC interrupt controller has no registers to set irq
trigger type, since it is always high level trigger. That means the
PMIC EIC controller as a child device of PMIC INTC does not need to
set the trigger type, so remove it.

Signed-off-by: Baolin Wang <[email protected]>
---
drivers/gpio/gpio-pmic-eic-sprd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c
index 29e044f..ac573da 100644
--- a/drivers/gpio/gpio-pmic-eic-sprd.c
+++ b/drivers/gpio/gpio-pmic-eic-sprd.c
@@ -322,7 +322,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev)

ret = devm_request_threaded_irq(&pdev->dev, pmic_eic->irq, NULL,
sprd_pmic_eic_irq_handler,
- IRQF_TRIGGER_LOW |
IRQF_ONESHOT | IRQF_NO_SUSPEND,
dev_name(&pdev->dev), pmic_eic);
if (ret) {
--
1.7.9.5

2019-01-21 12:49:13

by Linus Walleij

Subject: Re: [PATCH] gpio: sprd: Remove unused irq trigger setting

On Mon, Jan 21, 2019 at 6:06 AM Baolin Wang <[email protected]> wrote:

> The Spreadtrum PMIC interrupt controller has no registers to set irq
> trigger type, since it is always high level trigger. That means the
> PMIC EIC controller as a child device of PMIC INTC does not need to
> set the trigger type, so remove it.
>
> Signed-off-by: Baolin Wang <[email protected]>

Patch applied.

Yours,
Linus Walleij