On 6/15/23 10:00, Herbert Xu wrote:
[..]
>
> Good catch. Though I'd rather add the gfp argument to a separate
> function because I'm in the process of replacing ciphers with
> something that uses the new crypto_types API.
>
> Once that happens ciphers will switch over to the normal cloning
> call and this can be removed.
LGTM, thanks!
>
> ---8<---
> Use it straight away in crypto_clone_cipher(), as that is not meant to
> sleep.
>
> Fixes: 51d8d6d0f4be ("crypto: cipher - Add crypto_clone_cipher")
> Signed-off-by: Dmitry Safonov <[email protected]>
> Signed-off-by: Herbert Xu <[email protected]>
>
> diff --git a/crypto/api.c b/crypto/api.c
[..]
Thanks,
Dmitry
Hi Herbert,
On 6/15/23 17:19, Dmitry Safonov wrote:
> On 6/15/23 10:00, Herbert Xu wrote:
> [..]
>>
>> Good catch. Though I'd rather add the gfp argument to a separate
>> function because I'm in the process of replacing ciphers with
>> something that uses the new crypto_types API.
>>
>> Once that happens ciphers will switch over to the normal cloning
>> call and this can be removed.
>
> LGTM, thanks!
Would you prefer me to resend this v2 or you're happy to apply with your
proposed changes?
>> ---8<---
>> Use it straight away in crypto_clone_cipher(), as that is not meant to
>> sleep.
>>
>> Fixes: 51d8d6d0f4be ("crypto: cipher - Add crypto_clone_cipher")
>> Signed-off-by: Dmitry Safonov <[email protected]>
>> Signed-off-by: Herbert Xu <[email protected]>
>>
>> diff --git a/crypto/api.c b/crypto/api.c
> [..]
Thanks,
Dmitry