2020-10-05 16:26:06

by Enric Balletbo i Serra

Subject: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
introduced the following build warning with W=1

drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {

This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
anymore, so remove them.

Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Enric Balletbo i Serra <[email protected]>
---

drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 589ef33a1780..2609d917e3f9 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
return 0;
}

-static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
-{
- drm_encoder_cleanup(encoder);
-}
-
-static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
- .destroy = mtk_dpi_encoder_destroy,
-};
-
static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
enum drm_bridge_attach_flags flags)
{
--
2.28.0

2020-11-04 10:42:48

by Enric Balletbo i Serra

Subject: Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

Hi

On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> introduced the following build warning with W=1
>
> drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
> static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
>
> This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
> anymore, so remove them.
>
> Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Enric Balletbo i Serra <[email protected]>
> ---

A gentle ping on this small fix. Thanks,

Enric

>
> drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> index 589ef33a1780..2609d917e3f9 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> return 0;
> }
>
> -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
> -{
> - drm_encoder_cleanup(encoder);
> -}
> -
> -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> - .destroy = mtk_dpi_encoder_destroy,
> -};
> -
> static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
> enum drm_bridge_attach_flags flags)
> {
>

2020-11-04 23:53:46

by Chun-Kuang Hu

Subject: Re: [PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

Hi, Enric:

Enric Balletbo i Serra <[email protected]> 於 2020年11月4日 週三 下午6:40寫道：
>
> Hi
>
> On 5/10/20 18:22, Enric Balletbo i Serra wrote:
> > Commit f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > introduced the following build warning with W=1
> >
> > drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: unused variable 'mtk_dpi_encoder_funcs' [-Wunused-const-variable]
> > static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> >
> > This struct is and the 'mtk_dpi_encoder_destroy()' are not needed
> > anymore, so remove them.
> >
> > Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver")
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Enric Balletbo i Serra <[email protected]>
> > ---
>
> A gentle ping on this small fix. Thanks,

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Enric
>
> >
> > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > index 589ef33a1780..2609d917e3f9 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
> > @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
> > return 0;
> > }
> >
> > -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder)
> > -{
> > - drm_encoder_cleanup(encoder);
> > -}
> > -
> > -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = {
> > - .destroy = mtk_dpi_encoder_destroy,
> > -};
> > -
> > static int mtk_dpi_bridge_attach(struct drm_bridge *bridge,
> > enum drm_bridge_attach_flags flags)
> > {
> >