2018-01-16 08:16:54

by SF Markus Elfring

Subject: [PATCH 0/2] mfd: smsc-ece1099: Adjustments for smsc_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Tue, 16 Jan 2018 09:14:56 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/mfd/smsc-ece1099.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

--
2.15.1

2018-01-16 08:18:29

by SF Markus Elfring

Subject: [PATCH 1/2] mfd: smsc-ece1099: Delete an error message for a failed memory allocation in smsc_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Tue, 16 Jan 2018 08:52:27 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/smsc-ece1099.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index 93a8297de52a..b9d96651cc0d 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -39,10 +39,8 @@ static int smsc_i2c_probe(struct i2c_client *i2c,

smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc),
GFP_KERNEL);
- if (!smsc) {
- dev_err(&i2c->dev, "smsc mfd driver memory allocation failed\n");
+ if (!smsc)
return -ENOMEM;
- }

smsc->regmap = devm_regmap_init_i2c(i2c, &smsc_regmap_config);
if (IS_ERR(smsc->regmap))
--
2.15.1

2018-01-16 08:19:36

by SF Markus Elfring

Subject: [PATCH 2/2] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe()

From: Markus Elfring <[email protected]>
Date: Tue, 16 Jan 2018 08:58:26 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/smsc-ece1099.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
index b9d96651cc0d..6681205dd2c0 100644
--- a/drivers/mfd/smsc-ece1099.c
+++ b/drivers/mfd/smsc-ece1099.c
@@ -33,12 +33,10 @@ static const struct regmap_config smsc_regmap_config = {
static int smsc_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
- struct smsc *smsc;
int devid, rev, venid_l, venid_h;
int ret;
+ struct smsc *smsc = devm_kzalloc(&i2c->dev, sizeof(*smsc), GFP_KERNEL);

- smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc),
- GFP_KERNEL);
if (!smsc)
return -ENOMEM;

--
2.15.1

2018-01-23 09:51:46

by Lee Jones

Subject: Re: [PATCH 2/2] mfd: smsc-ece1099: Improve a size determination in smsc_i2c_probe()

On Tue, 16 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Tue, 16 Jan 2018 08:58:26 +0100
>
> Replace the specification of a data structure by a pointer dereference
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer according to the Linux coding style convention.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/smsc-ece1099.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c
> index b9d96651cc0d..6681205dd2c0 100644
> --- a/drivers/mfd/smsc-ece1099.c
> +++ b/drivers/mfd/smsc-ece1099.c
> @@ -33,12 +33,10 @@ static const struct regmap_config smsc_regmap_config = {
> static int smsc_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> - struct smsc *smsc;
> int devid, rev, venid_l, venid_h;
> int ret;
> + struct smsc *smsc = devm_kzalloc(&i2c->dev, sizeof(*smsc), GFP_KERNEL);

Please keep these separate.

> - smsc = devm_kzalloc(&i2c->dev, sizeof(struct smsc),
> - GFP_KERNEL);
> if (!smsc)
> return -ENOMEM;
>

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

2018-01-23 09:52:41

by Lee Jones

Subject: Re: [PATCH 1/2] mfd: smsc-ece1099: Delete an error message for a failed memory allocation in smsc_i2c_probe()

On Tue, 16 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Tue, 16 Jan 2018 08:52:27 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/smsc-ece1099.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog