On 11/17/2017 08:50 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> dev_alloc_skb can potentially return NULL, so add a null check to
> avoid a null pointer dereference on skb
Acked-by: Larry Finger <[email protected]>
Larry
>
> Detected by CoverityScan, CID#1454558 ("Dereference on null return")
>
> Fixes: 7e5b796cde7e ("staging: r8822be: Add the driver code")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/staging/rtlwifi/rtl8822be/fw.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/rtlwifi/rtl8822be/fw.c b/drivers/staging/rtlwifi/rtl8822be/fw.c
> index f45487122517..483ea85943c3 100644
> --- a/drivers/staging/rtlwifi/rtl8822be/fw.c
> +++ b/drivers/staging/rtlwifi/rtl8822be/fw.c
> @@ -464,6 +464,8 @@ bool rtl8822b_halmac_cb_write_data_rsvd_page(struct rtl_priv *rtlpriv, u8 *buf,
> int count;
>
> skb = dev_alloc_skb(size);
> + if (!skb)
> + return false;
> memcpy((u8 *)skb_put(skb, size), buf, size);
>
> if (!_rtl8822be_send_bcn_or_cmd_packet(rtlpriv->hw, skb, BEACON_QUEUE))
>
From 1584342234857172406@xxx Fri Nov 17 19:21:37 +0000 2017
X-GM-THRID: 1584342234857172406
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread