2023-04-20 07:28:07

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] media: dt-bindings: qcom: camss: correct unit address

Match unit-address to first reg entry.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml | 2 +-
Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
index 12ec3e1ea869..abd444e12d05 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
@@ -155,7 +155,7 @@ examples:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/clock/qcom,gcc-msm8916.h>

- camss: camss@1b00000 {
+ camss: camss@1b0ac00 {
compatible = "qcom,msm8916-camss";

clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>,
diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
index 6aeb3d6d02d5..db2604802d51 100644
--- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
@@ -221,7 +221,7 @@ examples:
#include <dt-bindings/clock/qcom,gcc-msm8996.h>
#include <dt-bindings/clock/qcom,mmcc-msm8996.h>

- camss: camss@a00000 {
+ camss: camss@a34000 {
compatible = "qcom,msm8996-camss";

clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
index b28c8e17f158..2f23baf32b61 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
@@ -227,7 +227,7 @@ examples:
#include <dt-bindings/clock/qcom,gcc-sdm660.h>
#include <dt-bindings/clock/qcom,mmcc-sdm660.h>

- camss: camss@ca00000 {
+ camss: camss@ca00020 {
compatible = "qcom,sdm660-camss";

clocks = <&mmcc CAMSS_AHB_CLK>,
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
index f9a003882f84..8f5c9aff37fb 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
@@ -219,7 +219,7 @@ examples:
#address-cells = <2>;
#size-cells = <2>;

- camss: camss@a00000 {
+ camss: camss@acb3000 {
compatible = "qcom,sdm845-camss";

clocks = <&clock_camcc CAM_CC_CAMNOC_AXI_CLK>,
--
2.34.1


2023-04-20 09:32:13

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: qcom: camss: correct unit address

On 20/04/2023 08:24, Krzysztof Kozlowski wrote:
> Match unit-address to first reg entry.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Bryan O'Donoghue <[email protected]>

2023-04-20 10:49:09

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: qcom: camss: correct unit address



On 20.04.2023 09:24, Krzysztof Kozlowski wrote:
> Match unit-address to first reg entry.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> index 12ec3e1ea869..abd444e12d05 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml
> @@ -155,7 +155,7 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/clock/qcom,gcc-msm8916.h>
>
> - camss: camss@1b00000 {
> + camss: camss@1b0ac00 {
> compatible = "qcom,msm8916-camss";
>
> clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>,
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 6aeb3d6d02d5..db2604802d51 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -221,7 +221,7 @@ examples:
> #include <dt-bindings/clock/qcom,gcc-msm8996.h>
> #include <dt-bindings/clock/qcom,mmcc-msm8996.h>
>
> - camss: camss@a00000 {
> + camss: camss@a34000 {
> compatible = "qcom,msm8996-camss";
>
> clocks = <&mmcc CAMSS_TOP_AHB_CLK>,
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> index b28c8e17f158..2f23baf32b61 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml
> @@ -227,7 +227,7 @@ examples:
> #include <dt-bindings/clock/qcom,gcc-sdm660.h>
> #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
>
> - camss: camss@ca00000 {
> + camss: camss@ca00020 {
> compatible = "qcom,sdm660-camss";
>
> clocks = <&mmcc CAMSS_AHB_CLK>,
> diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> index f9a003882f84..8f5c9aff37fb 100644
> --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml
> @@ -219,7 +219,7 @@ examples:
> #address-cells = <2>;
> #size-cells = <2>;
>
> - camss: camss@a00000 {
> + camss: camss@acb3000 {
> compatible = "qcom,sdm845-camss";
>
> clocks = <&clock_camcc CAM_CC_CAMNOC_AXI_CLK>,

2023-04-20 17:07:31

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] media: dt-bindings: qcom: camss: correct unit address


On Thu, 20 Apr 2023 09:24:42 +0200, Krzysztof Kozlowski wrote:
> Match unit-address to first reg entry.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml | 2 +-
> Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>

Acked-by: Rob Herring <[email protected]>