2019-09-20 16:15:58

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH 1/2] soc: ti: big cleanup of Kconfig file

From: Randy Dunlap <[email protected]>

Cleanup drivers/soc/ti/Kconfig:
- delete duplicate words
- end sentences with '.'
- fix typos/spellos
- Subsystem is one word
- capitalize acronyms
- reflow lines to be <= 80 columns

Fixes: 41f93af900a2 ("soc: ti: add Keystone Navigator QMSS driver")
Fixes: 88139ed03058 ("soc: ti: add Keystone Navigator DMA support")
Fixes: afe761f8d3e9 ("soc: ti: Add pm33xx driver for basic suspend support")
Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
Fixes: a869b7b30dac ("soc: ti: Add Support for AM654 SoC config option")
Fixes: cff377f7897a ("soc: ti: Add Support for J721E SoC config option")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Olof Johansson <[email protected]>
Cc: Santosh Shilimkar <[email protected]>
Cc: Sandeep Nair <[email protected]>
Cc: Dave Gerlach <[email protected]>
Cc: Keerthy <[email protected]>
Cc: Tony Lindgren <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
@Santosh: MAINTAINERS says that you maintain drivers/soc/ti/*,
but there is more that Keystone-related code in that subdirectory
now... just in case you want to update that info.

drivers/soc/ti/Kconfig | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

--- lnx-53.orig/drivers/soc/ti/Kconfig
+++ lnx-53/drivers/soc/ti/Kconfig
@@ -7,12 +7,12 @@ if ARCH_K3
config ARCH_K3_AM6_SOC
bool "K3 AM6 SoC"
help
- Enable support for TI's AM6 SoC Family support
+ Enable support for TI's AM6 SoC Family.

config ARCH_K3_J721E_SOC
bool "K3 J721E SoC"
help
- Enable support for TI's J721E SoC Family support
+ Enable support for TI's J721E SoC Family.

endif

@@ -27,7 +27,7 @@ menuconfig SOC_TI
if SOC_TI

config KEYSTONE_NAVIGATOR_QMSS
- tristate "Keystone Queue Manager Sub System"
+ tristate "Keystone Queue Manager Subsystem"
depends on ARCH_KEYSTONE
help
Say y here to support the Keystone multicore Navigator Queue
@@ -42,9 +42,9 @@ config KEYSTONE_NAVIGATOR_DMA
tristate "TI Keystone Navigator Packet DMA support"
depends on ARCH_KEYSTONE
help
- Say y tp enable support for the Keystone Navigator Packet DMA on
- on Keystone family of devices. It sets up the dma channels for the
- Queue Manager Sub System.
+ Say y to enable support for the Keystone Navigator Packet DMA on
+ on Keystone family of devices. It sets up the DMA channels for the
+ Queue Manager Subsystem.

If unsure, say N.

@@ -53,10 +53,10 @@ config AMX3_PM
depends on SOC_AM33XX || SOC_AM43XX
depends on WKUP_M3_IPC && TI_EMIF_SRAM && SRAM && RTC_DRV_OMAP
help
- Enable power management on AM335x and AM437x. Required for suspend to mem
- and standby states on both AM335x and AM437x platforms and for deeper cpuidle
- c-states on AM335x. Also required for rtc and ddr in self-refresh low
- power mode on AM437x platforms.
+ Enable power management on AM335x and AM437x. Required for suspend
+ to mem and standby states on both AM335x and AM437x platforms and
+ for deeper cpuidle c-states on AM335x. Also required for RTC and
+ DDR in self-refresh low power mode on AM437x platforms.

config WKUP_M3_IPC
tristate "TI AMx3 Wkup-M3 IPC Driver"


2019-09-20 16:34:45

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH 1/2] soc: ti: big cleanup of Kconfig file

On 9/19/19 6:14 PM, [email protected] wrote:
> On 9/19/19 3:33 PM, Randy Dunlap wrote:
>> From: Randy Dunlap <[email protected]>
>>
>> Cleanup drivers/soc/ti/Kconfig:
>> - delete duplicate words
>> - end sentences with '.'
>> - fix typos/spellos
>> - Subsystem is one word
>> - capitalize acronyms
>> - reflow lines to be <= 80 columns
>>
>> Fixes: 41f93af900a2 ("soc: ti: add Keystone Navigator QMSS driver")
>> Fixes: 88139ed03058 ("soc: ti: add Keystone Navigator DMA support")
>> Fixes: afe761f8d3e9 ("soc: ti: Add pm33xx driver for basic suspend support")
>> Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
>> Fixes: a869b7b30dac ("soc: ti: Add Support for AM654 SoC config option")
>> Fixes: cff377f7897a ("soc: ti: Add Support for J721E SoC config option")
>> Signed-off-by: Randy Dunlap <[email protected]>
>> Cc: Olof Johansson <[email protected]>
>> Cc: Santosh Shilimkar <[email protected]>
>> Cc: Sandeep Nair <[email protected]>
>> Cc: Dave Gerlach <[email protected]>
>> Cc: Keerthy <[email protected]>
>> Cc: Tony Lindgren <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>> ---
>> @Santosh: MAINTAINERS says that you maintain drivers/soc/ti/*,
>> but there is more that Keystone-related code in that subdirectory
>> now... just in case you want to update that info.
>>
> Yes am aware there more drivers and so far I have been taking
> care of everything in drivers/soc/ti/*

OK :)

>>   drivers/soc/ti/Kconfig |   20 ++++++++++----------
>>   1 file changed, 10 insertions(+), 10 deletions(-)
>>
> Patch looks fine to me. Do you want me to pick this up ?
>

Yes, please.

--
~Randy

2019-09-20 21:28:54

by Santosh Shilimkar

[permalink] [raw]
Subject: Re: [PATCH 1/2] soc: ti: big cleanup of Kconfig file

On 9/19/19 3:33 PM, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Cleanup drivers/soc/ti/Kconfig:
> - delete duplicate words
> - end sentences with '.'
> - fix typos/spellos
> - Subsystem is one word
> - capitalize acronyms
> - reflow lines to be <= 80 columns
>
> Fixes: 41f93af900a2 ("soc: ti: add Keystone Navigator QMSS driver")
> Fixes: 88139ed03058 ("soc: ti: add Keystone Navigator DMA support")
> Fixes: afe761f8d3e9 ("soc: ti: Add pm33xx driver for basic suspend support")
> Fixes: 5a99ae0092fe ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
> Fixes: a869b7b30dac ("soc: ti: Add Support for AM654 SoC config option")
> Fixes: cff377f7897a ("soc: ti: Add Support for J721E SoC config option")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Olof Johansson <[email protected]>
> Cc: Santosh Shilimkar <[email protected]>
> Cc: Sandeep Nair <[email protected]>
> Cc: Dave Gerlach <[email protected]>
> Cc: Keerthy <[email protected]>
> Cc: Tony Lindgren <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
> @Santosh: MAINTAINERS says that you maintain drivers/soc/ti/*,
> but there is more that Keystone-related code in that subdirectory
> now... just in case you want to update that info.
>
Yes am aware there more drivers and so far I have been taking
care of everything in drivers/soc/ti/*

> drivers/soc/ti/Kconfig | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
Patch looks fine to me. Do you want me to pick this up ?