2020-04-15 21:58:39

by Vitor Massaru Iha

Subject: [PATCH] kunit: use KUnit defconfig by default

To improve the usability of KUnit, defconfig is used
by default if no kunitconfig is present.

* https://bugzilla.kernel.org/show_bug.cgi?id=205259

Signed-off-by: Vitor Massaru Iha <[email protected]>
---
tools/testing/kunit/kunit.py | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
index 7dca74774dd2..4b98f6e75e4c 100755
--- a/tools/testing/kunit/kunit.py
+++ b/tools/testing/kunit/kunit.py
@@ -23,8 +23,8 @@ import kunit_parser
KunitResult = namedtuple('KunitResult', ['status','result'])

KunitRequest = namedtuple('KunitRequest', ['raw_output','timeout', 'jobs',
- 'build_dir', 'defconfig',
- 'alltests', 'make_options'])
+ 'build_dir', 'alltests',
+ 'make_options'])

KernelDirectoryPath = sys.argv[0].split('tools/testing/kunit/')[0]

@@ -118,10 +118,6 @@ def main(argv, linux=None):
'directory.',
type=str, default='', metavar='build_dir')

- run_parser.add_argument('--defconfig',
- help='Uses a default .kunitconfig.',
- action='store_true')
-
run_parser.add_argument('--alltests',
help='Run all KUnit tests through allyesconfig',
action='store_true')
@@ -143,8 +139,7 @@ def main(argv, linux=None):
cli_args.build_dir,
kunit_kernel.kunitconfig_path)

- if cli_args.defconfig:
- create_default_kunitconfig()
+ create_default_kunitconfig()

if not linux:
linux = kunit_kernel.LinuxSourceTree()
@@ -153,7 +148,6 @@ def main(argv, linux=None):
cli_args.timeout,
cli_args.jobs,
cli_args.build_dir,
- cli_args.defconfig,
cli_args.alltests,
cli_args.make_options)
result = run_tests(linux, request)
--
2.25.1

2020-04-16 23:22:34

by Brendan Higgins

Subject: Re: [PATCH] kunit: use KUnit defconfig by default

On Tue, Apr 14, 2020 at 4:37 PM Vitor Massaru Iha <[email protected]> wrote:
>
> To improve the usability of KUnit, defconfig is used
> by default if no kunitconfig is present.
>
> * https://bugzilla.kernel.org/show_bug.cgi?id=205259
>
> Signed-off-by: Vitor Massaru Iha <[email protected]>

Reviewed-by: Brendan Higgins <[email protected]>

2020-05-22 22:42:28

by Shuah Khan

Subject: Re: [PATCH] kunit: use KUnit defconfig by default

On 4/16/20 5:20 PM, Brendan Higgins wrote:
> On Tue, Apr 14, 2020 at 4:37 PM Vitor Massaru Iha <[email protected]> wrote:
>>
>> To improve the usability of KUnit, defconfig is used
>> by default if no kunitconfig is present.
>>
>> * https://bugzilla.kernel.org/show_bug.cgi?id=205259
>>
>> Signed-off-by: Vitor Massaru Iha <[email protected]>
>
> Reviewed-by: Brendan Higgins <[email protected]>
>

Applied the patch to kselftest/kunit on top of

45ba7a893ad89114e773b3dc32f6431354c465d6
kunit: kunit_tool: Separate out config/build/exec/parse

from David's work resolving merge conflicts. Please check if it is
sane.

thanks,
-- Shuah