2024-01-24 16:47:50

by Daniel Golle

Subject: [PATCH net] net: ethernet: mtk_eth_soc: set DMA coherent mask to get PPE working

Set DMA coherent mask to 32-bit which makes PPE offloading engine start
working on BPi-R4 which got 4 GiB of RAM.

Fixes: 2d75891ebc09 ("net: ethernet: mtk_eth_soc: support 36-bit DMA addressing on MT7988")
Suggested-by: Elad Yifee <[email protected]>
Signed-off-by: Daniel Golle <[email protected]>
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index a6e91573f8dae..de123350bd46b 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -4761,7 +4761,10 @@ static int mtk_probe(struct platform_device *pdev)
}

if (MTK_HAS_CAPS(eth->soc->caps, MTK_36BIT_DMA)) {
- err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(36));
+ err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(36));
+ if (!err)
+ err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(32));
+
if (err) {
dev_err(&pdev->dev, "Wrong DMA config\n");
return -EINVAL;
--
2.43.0

2024-01-26 01:40:46

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: set DMA coherent mask to get PPE working

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

On Wed, 24 Jan 2024 16:22:09 +0000 you wrote:
> Set DMA coherent mask to 32-bit which makes PPE offloading engine start
> working on BPi-R4 which got 4 GiB of RAM.
>
> Fixes: 2d75891ebc09 ("net: ethernet: mtk_eth_soc: support 36-bit DMA addressing on MT7988")
> Suggested-by: Elad Yifee <[email protected]>
> Signed-off-by: Daniel Golle <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: ethernet: mtk_eth_soc: set DMA coherent mask to get PPE working
https://git.kernel.org/netdev/net/c/cae1f1c36661

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html