2024-04-23 07:37:51

by Kunwu Chan

Subject: [PATCH] KVM: selftests: Add 'malloc' failure check in config_name

There is a 'malloc' call in config_name function, which can
be unsuccessful. This patch will add the malloc failure checking
to avoid possible null dereference and give more information
about test fail reasons.

Signed-off-by: Kunwu Chan <[email protected]>
---
tools/testing/selftests/kvm/get-reg-list.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c
index 91f05f78e824..22398696ffd6 100644
--- a/tools/testing/selftests/kvm/get-reg-list.c
+++ b/tools/testing/selftests/kvm/get-reg-list.c
@@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c)
len += strlen(s->name) + 1;

c->name = malloc(len);
+ TEST_ASSERT(c->name, "-ENOMEM when allocating config name");

len = 0;
for_each_sublist(c, s) {
--
2.40.1

2024-04-23 08:50:13

by Muhammad Usama Anjum

Subject: Re: [PATCH] KVM: selftests: Add 'malloc' failure check in config_name

On 4/23/24 12:37 PM, Kunwu Chan wrote:
> There is a 'malloc' call in config_name function, which can
> be unsuccessful. This patch will add the malloc failure checking
> to avoid possible null dereference and give more information
> about test fail reasons.
>
> Signed-off-by: Kunwu Chan <[email protected]>
LGTM

Reviewed-by: Muhammad Usama Anjum <[email protected]>

> ---
> tools/testing/selftests/kvm/get-reg-list.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/kvm/get-reg-list.c b/tools/testing/selftests/kvm/get-reg-list.c
> index 91f05f78e824..22398696ffd6 100644
> --- a/tools/testing/selftests/kvm/get-reg-list.c
> +++ b/tools/testing/selftests/kvm/get-reg-list.c
> @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c)
> len += strlen(s->name) + 1;
>
> c->name = malloc(len);
> + TEST_ASSERT(c->name, "-ENOMEM when allocating config name");
>
> len = 0;
> for_each_sublist(c, s) {

--
BR,
Muhammad Usama Anjum

2024-04-23 11:12:40

by Markus Elfring

Subject: Re: [PATCH] KVM: selftests: Add 'malloc' failure check in config_name

…
> This patch will add the malloc failure checking
…

* Please use a corresponding imperative wording for the change description.

* Would you like to add the tag “Fixes” accordingly?


…
> +++ b/tools/testing/selftests/kvm/get-reg-list.c
> @@ -66,6 +66,7 @@ static const char *config_name(struct vcpu_reg_list *c)
> len += strlen(s->name) + 1;
>
> c->name = malloc(len);
> + TEST_ASSERT(c->name, "-ENOMEM when allocating config name");
…

Can “errno” be relevant for the error message construction?

Regards,
Markus