From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 15:27:38 +0100
Three update suggestions were taken into account
from static source code analysis.
Markus Elfring (3):
Delete an error message for a failed memory allocation in two functions
Improve four size determinations
Delete an unnecessary return statement in oaktrail_crtc_hdmi_dpms()
drivers/gpu/drm/gma500/framebuffer.c | 7 ++-----
drivers/gpu/drm/gma500/oaktrail_hdmi.c | 13 ++++---------
2 files changed, 6 insertions(+), 14 deletions(-)
--
2.16.1
From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 14:55:49 +0100
Omit an extra message for a memory allocation failure in these functions.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpu/drm/gma500/framebuffer.c | 4 +---
drivers/gpu/drm/gma500/oaktrail_hdmi.c | 5 +----
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index cb0a2ae916e0..3ff320f3ff47 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -530,10 +530,8 @@ int psb_fbdev_init(struct drm_device *dev)
int ret;
fbdev = kzalloc(sizeof(struct psb_fbdev), GFP_KERNEL);
- if (!fbdev) {
- dev_err(dev->dev, "no memory\n");
+ if (!fbdev)
return -ENOMEM;
- }
dev_priv->fbdev = fbdev;
diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
index 8b2eb32ee988..d9a6d54b6641 100644
--- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
+++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
@@ -690,11 +690,8 @@ void oaktrail_hdmi_setup(struct drm_device *dev)
return;
hdmi_dev = kzalloc(sizeof(struct oaktrail_hdmi_dev), GFP_KERNEL);
- if (!hdmi_dev) {
- dev_err(dev->dev, "failed to allocate memory\n");
+ if (!hdmi_dev)
goto out;
- }
-
ret = pci_enable_device(pdev);
if (ret) {
--
2.16.1
From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 15:08:39 +0100
Replace the specification of data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpu/drm/gma500/framebuffer.c | 3 +--
drivers/gpu/drm/gma500/oaktrail_hdmi.c | 6 +++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index 3ff320f3ff47..ad96a542d137 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -525,11 +525,10 @@ static int psb_fbdev_destroy(struct drm_device *dev, struct psb_fbdev *fbdev)
int psb_fbdev_init(struct drm_device *dev)
{
- struct psb_fbdev *fbdev;
struct drm_psb_private *dev_priv = dev->dev_private;
int ret;
+ struct psb_fbdev *fbdev = kzalloc(sizeof(*fbdev), GFP_KERNEL);
- fbdev = kzalloc(sizeof(struct psb_fbdev), GFP_KERNEL);
if (!fbdev)
return -ENOMEM;
diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
index d9a6d54b6641..dbc58e5130bb 100644
--- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
+++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
@@ -637,11 +637,11 @@ void oaktrail_hdmi_init(struct drm_device *dev,
struct drm_connector *connector;
struct drm_encoder *encoder;
- gma_encoder = kzalloc(sizeof(struct gma_encoder), GFP_KERNEL);
+ gma_encoder = kzalloc(sizeof(*gma_encoder), GFP_KERNEL);
if (!gma_encoder)
return;
- gma_connector = kzalloc(sizeof(struct gma_connector), GFP_KERNEL);
+ gma_connector = kzalloc(sizeof(*gma_connector), GFP_KERNEL);
if (!gma_connector)
goto failed_connector;
@@ -689,7 +689,7 @@ void oaktrail_hdmi_setup(struct drm_device *dev)
if (!pdev)
return;
- hdmi_dev = kzalloc(sizeof(struct oaktrail_hdmi_dev), GFP_KERNEL);
+ hdmi_dev = kzalloc(sizeof(*hdmi_dev), GFP_KERNEL);
if (!hdmi_dev)
goto out;
--
2.16.1
From: Markus Elfring <[email protected]>
Date: Thu, 8 Feb 2018 15:17:48 +0100
The script "checkpatch.pl" pointed information out like the following.
WARNING: void function return statements are not generally useful
Thus remove such a statement in the affected function.
Signed-off-by: Markus Elfring <[email protected]>
---
drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi.c b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
index dbc58e5130bb..24c7c6edfca5 100644
--- a/drivers/gpu/drm/gma500/oaktrail_hdmi.c
+++ b/drivers/gpu/drm/gma500/oaktrail_hdmi.c
@@ -484,8 +484,6 @@ void oaktrail_crtc_hdmi_dpms(struct drm_crtc *crtc, int mode)
/* LNC Chicken Bits - Squawk! */
REG_WRITE(0x70400, 0x4000);
-
- return;
}
static void oaktrail_hdmi_dpms(struct drm_encoder *encoder, int mode)
--
2.16.1