2007-05-23 13:23:48

by Jan Altenberg

Subject: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

ucc_geth has been migrated to use the common phylib code. So lets add a
'select PHYLIB' to the UCC_GETH Kconfig entry.

Signed-off-by: Jan Altenberg <[email protected]>

---
drivers/net/Kconfig | 1 +
1 file changed, 1 insertion(+)

Index: linux-2.6/drivers/net/Kconfig
===================================================================
--- linux-2.6.orig/drivers/net/Kconfig
+++ linux-2.6/drivers/net/Kconfig
@@ -2280,6 +2280,7 @@ config GFAR_NAPI
config UCC_GETH
tristate "Freescale QE Gigabit Ethernet"
depends on QUICC_ENGINE
+ select PHYLIB
select UCC_FAST
help
This driver supports the Gigabit Ethernet mode of the QUICC Engine,

2007-05-24 21:48:21

by Jeff Garzik

Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

Jan Altenberg wrote:
> ucc_geth has been migrated to use the common phylib code. So lets add a
> 'select PHYLIB' to the UCC_GETH Kconfig entry.
>
> Signed-off-by: Jan Altenberg <[email protected]>
>
> ---
> drivers/net/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: linux-2.6/drivers/net/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/net/Kconfig
> +++ linux-2.6/drivers/net/Kconfig
> @@ -2280,6 +2280,7 @@ config GFAR_NAPI
> config UCC_GETH
> tristate "Freescale QE Gigabit Ethernet"
> depends on QUICC_ENGINE
> + select PHYLIB
> select UCC_FAST

Please fix the Kconfig warnings first.

Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?

I am tired of five independent people patching the same driver.

Jeff

2007-05-25 03:45:43

by Li Yang

Subject: RE: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option

> -----Original Message-----
> From: [email protected]
[mailto:[email protected]] On
> Behalf Of Jeff Garzik
> Sent: Friday, May 25, 2007 5:48 AM
> To: Jan Altenberg
> Cc: Phillips Kim-R1AAHA; [email protected];
[email protected]
> Subject: Re: [PATCH] Add select PHYLIB to the UCC_GETH Kconfig option
>
> Jan Altenberg wrote:
> > ucc_geth has been migrated to use the common phylib code. So lets
add a
> > 'select PHYLIB' to the UCC_GETH Kconfig entry.
> >
> > Signed-off-by: Jan Altenberg <[email protected]>
> >
> > ---
> > drivers/net/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > Index: linux-2.6/drivers/net/Kconfig
> > ===================================================================
> > --- linux-2.6.orig/drivers/net/Kconfig
> > +++ linux-2.6/drivers/net/Kconfig
> > @@ -2280,6 +2280,7 @@ config GFAR_NAPI
> > config UCC_GETH
> > tristate "Freescale QE Gigabit Ethernet"
> > depends on QUICC_ENGINE
> > + select PHYLIB
> > select UCC_FAST
>
> Please fix the Kconfig warnings first.
>

I will follow up this.

> Also, I ask again: WHO IS THE MAINTAINER OF THIS DRIVER?
>
> I am tired of five independent people patching the same driver.

Sorry for the trouble, I will post a patch to the MAINTAINER file and
help to maintain ucc_geth related patches.

- Leo