2018-03-01 20:17:53

by Shuah Khan

Subject: [PATCH] selftests: memory-hotplug: fix emit_tests regression

Commit 16c513b13477
("selftests: memory-hotplug: silence test command echo")

introduced regression in emit_tests and results in the following
failure when selftests are installed and run. Fix it.

Running tests in memory-hotplug
========================================
./run_kselftest.sh: line 121: @./mem-on-off-test.sh: No such file or
directory
selftests: memory-hotplug [FAIL]

Fixes: 16c513b13477 (selftests: memory-hotplug: silence test command echo")
Reported-by: Naresh Kamboju <[email protected]>
Signed-off-by: Shuah Khan <[email protected]>
---
tools/testing/selftests/memory-hotplug/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
index 183b46883875..686da510f989 100644
--- a/tools/testing/selftests/memory-hotplug/Makefile
+++ b/tools/testing/selftests/memory-hotplug/Makefile
@@ -5,7 +5,8 @@ include ../lib.mk

TEST_PROGS := mem-on-off-test.sh
override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
-override EMIT_TESTS := echo "$(RUN_TESTS)"
+
+override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))"

run_full_test:
@/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
--
2.14.1

2018-03-02 08:32:12

by Anders Roxell

Subject: Re: [PATCH] selftests: memory-hotplug: fix emit_tests regression

On 1 March 2018 at 21:16, Shuah Khan <[email protected]> wrote:
> Commit 16c513b13477
> ("selftests: memory-hotplug: silence test command echo")
>
> introduced regression in emit_tests and results in the following
> failure when selftests are installed and run. Fix it.
>
> Running tests in memory-hotplug
> ========================================
> ./run_kselftest.sh: line 121: @./mem-on-off-test.sh: No such file or
> directory
> selftests: memory-hotplug [FAIL]
>
> Fixes: 16c513b13477 (selftests: memory-hotplug: silence test command echo")
> Reported-by: Naresh Kamboju <[email protected]>
> Signed-off-by: Shuah Khan <[email protected]>

Tested-by: Anders Roxell <[email protected]>

> ---
> tools/testing/selftests/memory-hotplug/Makefile | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/memory-hotplug/Makefile b/tools/testing/selftests/memory-hotplug/Makefile
> index 183b46883875..686da510f989 100644
> --- a/tools/testing/selftests/memory-hotplug/Makefile
> +++ b/tools/testing/selftests/memory-hotplug/Makefile
> @@ -5,7 +5,8 @@ include ../lib.mk
>
> TEST_PROGS := mem-on-off-test.sh
> override RUN_TESTS := @./mem-on-off-test.sh -r 2 && echo "selftests: memory-hotplug [PASS]" || echo "selftests: memory-hotplug [FAIL]"
> -override EMIT_TESTS := echo "$(RUN_TESTS)"
> +
> +override EMIT_TESTS := echo "$(subst @,,$(RUN_TESTS))"
>
> run_full_test:
> @/bin/bash ./mem-on-off-test.sh && echo "memory-hotplug selftests: [PASS]" || echo "memory-hotplug selftests: [FAIL]"
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2018-03-02 17:18:43

by Shuah Khan

Subject: Re: [PATCH] selftests: memory-hotplug: fix emit_tests regression

On 03/02/2018 01:31 AM, Anders Roxell wrote:
> On 1 March 2018 at 21:16, Shuah Khan <[email protected]> wrote:
>> Commit 16c513b13477
>> ("selftests: memory-hotplug: silence test command echo")
>>
>> introduced regression in emit_tests and results in the following
>> failure when selftests are installed and run. Fix it.
>>
>> Running tests in memory-hotplug
>> ========================================
>> ./run_kselftest.sh: line 121: @./mem-on-off-test.sh: No such file or
>> directory
>> selftests: memory-hotplug [FAIL]
>>
>> Fixes: 16c513b13477 (selftests: memory-hotplug: silence test command echo")
>> Reported-by: Naresh Kamboju <[email protected]>
>> Signed-off-by: Shuah Khan <[email protected]>
>
> Tested-by: Anders Roxell <[email protected]>
>

Thanks for testing. It is now in linux-kselftest fixes for the next
4.16-rc

thanks,
-- Shuah