2020-02-20 01:32:12

by Baolin Wang

Subject: [PATCH] mmc: host: hsq: Add missing MODULE_LICENSE() and MODULE_DESCRIPTION()

Add missing MODULE_LICENSE() and MODULE_DESCRIPTION() in hsq driver to
fix below warning when compiling the hsq as a module.

"WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/mmc_hsq.o".

Fixes: eb1814dd49d5 ("mmc: Add MMC host software queue support")
Reported-by: Stephen Rothwell <[email protected]>
Signed-off-by: Baolin Wang <[email protected]>
---
drivers/mmc/host/mmc_hsq.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/host/mmc_hsq.c b/drivers/mmc/host/mmc_hsq.c
index 2011988..59d2776 100644
--- a/drivers/mmc/host/mmc_hsq.c
+++ b/drivers/mmc/host/mmc_hsq.c
@@ -8,6 +8,7 @@

#include <linux/mmc/card.h>
#include <linux/mmc/host.h>
+#include <linux/module.h>

#include "mmc_hsq.h"

@@ -341,3 +342,6 @@ int mmc_hsq_resume(struct mmc_host *mmc)
return mmc_hsq_enable(mmc, NULL);
}
EXPORT_SYMBOL_GPL(mmc_hsq_resume);
+
+MODULE_DESCRIPTION("MMC Host Software Queue support");
+MODULE_LICENSE("GPL v2");
--
1.7.9.5

2020-02-21 14:34:30

by Ulf Hansson

Subject: Re: [PATCH] mmc: host: hsq: Add missing MODULE_LICENSE() and MODULE_DESCRIPTION()

On Thu, 20 Feb 2020 at 02:31, Baolin Wang <[email protected]> wrote:
>
> Add missing MODULE_LICENSE() and MODULE_DESCRIPTION() in hsq driver to
> fix below warning when compiling the hsq as a module.
>
> "WARNING: modpost: missing MODULE_LICENSE() in drivers/mmc/host/mmc_hsq.o".
>
> Fixes: eb1814dd49d5 ("mmc: Add MMC host software queue support")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Baolin Wang <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

> ---
> drivers/mmc/host/mmc_hsq.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mmc/host/mmc_hsq.c b/drivers/mmc/host/mmc_hsq.c
> index 2011988..59d2776 100644
> --- a/drivers/mmc/host/mmc_hsq.c
> +++ b/drivers/mmc/host/mmc_hsq.c
> @@ -8,6 +8,7 @@
>
> #include <linux/mmc/card.h>
> #include <linux/mmc/host.h>
> +#include <linux/module.h>
>
> #include "mmc_hsq.h"
>
> @@ -341,3 +342,6 @@ int mmc_hsq_resume(struct mmc_host *mmc)
> return mmc_hsq_enable(mmc, NULL);
> }
> EXPORT_SYMBOL_GPL(mmc_hsq_resume);
> +
> +MODULE_DESCRIPTION("MMC Host Software Queue support");
> +MODULE_LICENSE("GPL v2");
> --
> 1.7.9.5
>