2024-04-26 01:47:34

by Klymenko, Anatoliy

Subject: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats().

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 423f5f4943cc..c9fb432d4cbd 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct zynqmp_disp_layer *layer,
unsigned int i;
u32 *formats;

- if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
+ if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
*num_formats = 0;
return NULL;
}

--
2.25.1

2024-04-26 06:37:27

by Tomi Valkeinen

Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

On 26/04/2024 04:46, Anatoliy Klymenko wrote:
> Fix W=1 clang 19 compilation error in zynqmp_disp_layer_drm_formats().
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> ---

This is missing your signed-off-by.

Tomi

> drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 423f5f4943cc..c9fb432d4cbd 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct zynqmp_disp_layer *layer,
> unsigned int i;
> u32 *formats;
>
> - if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> + if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> *num_formats = 0;
> return NULL;
> }
>

2024-04-26 19:47:34

by Klymenko, Anatoliy

Subject: RE: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation error

> -----Original Message-----
> From: Tomi Valkeinen <[email protected]>
> Sent: Thursday, April 25, 2024 11:36 PM
> To: Klymenko, Anatoliy <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; kernel test robot <[email protected]>; Laurent
> Pinchart <[email protected]>; Maarten Lankhorst
> <[email protected]>; Maxime Ripard
> <[email protected]>; Thomas Zimmermann <[email protected]>;
> David Airlie <[email protected]>; Daniel Vetter <[email protected]>;
> Simek, Michal <[email protected]>
> Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation
> error
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On 26/04/2024 04:46, Anatoliy Klymenko wrote:
> > Fix W=1 clang 19 compilation error in
> zynqmp_disp_layer_drm_formats().
> >
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-
> [email protected]/
> > ---
>
> This is missing your signed-off-by.
>
> Tomi

Thank you!

>
> > drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 423f5f4943cc..c9fb432d4cbd 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct
> zynqmp_disp_layer *layer,
> > unsigned int i;
> > u32 *formats;
> >
> > - if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> > + if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> > *num_formats = 0;
> > return NULL;
> > }
> >