>From bfafcd3a39e13c3f6cedf9cc8eff2efdc9af7271 Mon Sep 17 00:00:00 2001
From: Tim Gardner <[email protected]>
Date: Wed, 30 Sep 2009 14:30:08 -0600
Subject: [PATCH] e1000e: Fix PCIE error message
BugLink: http://bugs.launchpad.net/bugs/436370
The error returned by pci_enable_pcie_error_reporting() is ignored, so
print a notice instead of an error. Users tends to freak out
when they see messages like this.
Signed-off-by: Tim Gardner <[email protected]>
Cc: [email protected]
---
drivers/net/e1000e/netdev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 16c193a..69a761a 100644
--- a/drivers/net/e1000e/netdev.c
+++ b/drivers/net/e1000e/netdev.c
@@ -4984,7 +4984,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
/* AER (Advanced Error Reporting) hooks */
err = pci_enable_pcie_error_reporting(pdev);
if (err) {
- dev_err(&pdev->dev, "pci_enable_pcie_error_reporting failed "
+ dev_notice(&pdev->dev, "pci_enable_pcie_error_reporting failed "
"0x%x\n", err);
/* non-fatal, continue */
}
--
1.6.2.4
Tim Gardner wrote:
> Subject: [PATCH] e1000e: Fix PCIE error message
>
> BugLink: http://bugs.launchpad.net/bugs/436370
>
> The error returned by pci_enable_pcie_error_reporting() is ignored, so
> print a notice instead of an error. Users tends to freak out
> when they see messages like this.
There's already a patch in the pipeline that removes the error message
completely. See http://lkml.org/lkml/2009/8/21/39 for the final version.
I'm not sure why it isn't included in 2.6.31 yet as it was acked by Jeff.
Cheers.
FJP
On Wed, Sep 30, 2009 at 14:28, Frans Pop <[email protected]> wrote:
> Tim Gardner wrote:
>> Subject: [PATCH] e1000e: Fix PCIE error message
>>
>> BugLink: http://bugs.launchpad.net/bugs/436370
>>
>> The error returned by pci_enable_pcie_error_reporting() is ignored, so
>> print a notice instead of an error. Users tends to freak out
>> when they see messages like this.
>
> There's already a patch in the pipeline that removes the error message
> completely. See http://lkml.org/lkml/2009/8/21/39 for the final version.
>
> I'm not sure why it isn't included in 2.6.31 yet as it was acked by Jeff.
>
I will add Fran's patch to my queue of patches and resend to
Dave/netdev and I will make sure it also gets submitted to 2.6.31
stable tree once it gets merged upstream. I apologize for not
catching that this got overlooked.
--
Cheers,
Jeff