2010-11-03 04:25:40

by Cong Wang

[permalink] [raw]
Subject: [Patch] netxen: remove unused firmware exports


Quote from Amit Salecha:

"Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already
submitted and its present in linux-firmware.git.

I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and
NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?"

We have to remove these, otherwise we will get wrong info from modinfo.

Signed-off-by: WANG Cong <[email protected]>
Cc: Amit Kumar Salecha <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Dhananjay Phadke <[email protected]>
Cc: Narender Kumar <[email protected]>

---
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 50820be..5ddf112 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -41,9 +41,6 @@
MODULE_DESCRIPTION("QLogic/NetXen (1/10) GbE Converged Ethernet Driver");
MODULE_LICENSE("GPL");
MODULE_VERSION(NETXEN_NIC_LINUX_VERSIONID);
-MODULE_FIRMWARE(NX_P2_MN_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_CT_ROMIMAGE_NAME);
-MODULE_FIRMWARE(NX_P3_MN_ROMIMAGE_NAME);
MODULE_FIRMWARE(NX_UNIFIED_ROMIMAGE_NAME);

char netxen_nic_driver_name[] = "netxen_nic";


2010-11-03 09:36:46

by Amit Salecha

[permalink] [raw]
Subject: RE: [Patch] netxen: remove unused firmware exports

> From: Amerigo Wang [[email protected]]
> Sent: Wednesday, November 03, 2010 9:55 AM
> To: [email protected]
> Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; [email protected]; David S. Miller; Amerigo Wang
> Subject: [Patch] netxen: remove unused firmware exports
>
> Quote from Amit Salecha:
>
> "Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already
> submitted and its present in linux-firmware.git.
>
> I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and
> NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?"
>
> We have to remove these, otherwise we will get wrong info from modinfo.
>
> Signed-off-by: WANG Cong <[email protected]>
> Cc: Amit Kumar Salecha <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Dhananjay Phadke <[email protected]>
> Cc: Narender Kumar [email protected]

Acked-by: Amit Kumar Salecha <[email protected]>-

2010-11-04 01:57:37

by David Miller

[permalink] [raw]
Subject: Re: [Patch] netxen: remove unused firmware exports

From: Amit Salecha <[email protected]>
Date: Wed, 3 Nov 2010 04:35:01 -0500

>> From: Amerigo Wang [[email protected]]
>> Sent: Wednesday, November 03, 2010 9:55 AM
>> To: [email protected]
>> Cc: Dhananjay Phadke; Amit Salecha; Narender Kumar; [email protected]; David S. Miller; Amerigo Wang
>> Subject: [Patch] netxen: remove unused firmware exports
>>
>> Quote from Amit Salecha:
>>
>> "Actually I was not updated, NX_UNIFIED_ROMIMAGE_NAME (phanfw.bin) is already
>> submitted and its present in linux-firmware.git.
>>
>> I will get back to you on NX_P2_MN_ROMIMAGE_NAME, NX_P3_CT_ROMIMAGE_NAME and
>> NX_P3_MN_ROMIMAGE_NAME. Whether this will be submitted ?"
>>
>> We have to remove these, otherwise we will get wrong info from modinfo.
>>
>> Signed-off-by: WANG Cong <[email protected]>
>> Cc: Amit Kumar Salecha <[email protected]>
>> Cc: "David S. Miller" <[email protected]>
>> Cc: Dhananjay Phadke <[email protected]>
>> Cc: Narender Kumar [email protected]
>
> Acked-by: Amit Kumar Salecha <[email protected]>

Applied.