2022-04-28 12:52:12

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 4/4] m68knommu: allow elf_fdpic loader to be selected

Hi Greg,

On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer <[email protected]> wrote:
> The m68k architecture code is capable of supporting the binfmt_elf_fdpic
> loader, so allow it to be configured. It is restricted to nommu
> configurations at this time due to the MMU context structures/code not
> supporting everything elf_fdpic needs when MMU is enabled.
>
> Signed-off-by: Greg Ungerer <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

> --- a/fs/Kconfig.binfmt
> +++ b/fs/Kconfig.binfmt
> @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY
> config BINFMT_ELF_FDPIC
> bool "Kernel support for FDPIC ELF binaries"
> default y if !BINFMT_ELF
> - depends on (ARM || (SUPERH && !MMU))
> + depends on (ARM || ((M68K || SUPERH) && !MMU))

While at it, you may want to drop the unneeded outer parentheses,
as they make the expression harder to round, IMHO.

> select ELFCORE
> help
> ELF FDPIC binaries are based on ELF, but allow the individual load

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2022-04-29 08:31:50

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH 4/4] m68knommu: allow elf_fdpic loader to be selected

Hi Geert,

On 28/4/22 17:20, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Thu, Apr 28, 2022 at 7:05 AM Greg Ungerer <[email protected]> wrote:
>> The m68k architecture code is capable of supporting the binfmt_elf_fdpic
>> loader, so allow it to be configured. It is restricted to nommu
>> configurations at this time due to the MMU context structures/code not
>> supporting everything elf_fdpic needs when MMU is enabled.
>>
>> Signed-off-by: Greg Ungerer <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
>
>> --- a/fs/Kconfig.binfmt
>> +++ b/fs/Kconfig.binfmt
>> @@ -58,7 +58,7 @@ config ARCH_USE_GNU_PROPERTY
>> config BINFMT_ELF_FDPIC
>> bool "Kernel support for FDPIC ELF binaries"
>> default y if !BINFMT_ELF
>> - depends on (ARM || (SUPERH && !MMU))
>> + depends on (ARM || ((M68K || SUPERH) && !MMU))
>
> While at it, you may want to drop the unneeded outer parentheses,
> as they make the expression harder to round, IMHO.

Sure thing, will do,

Regards
Greg


>> select ELFCORE
>> help
>> ELF FDPIC binaries are based on ELF, but allow the individual load
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds