2018-01-21 18:50:44

by SF Markus Elfring

Subject: [PATCH 0/2] Input-egalax_ts: Adjustments for egalax_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 19:46:54 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/touchscreen/egalax_ts.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

--
2.16.0

2018-01-21 18:51:54

by SF Markus Elfring

Subject: [PATCH 1/2] Input: egalax_ts: Delete an error message for a failed memory allocation in egalax_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 19:34:38 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/egalax_ts.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 752ae9cf4514..29ec1166626d 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -172,10 +172,8 @@ static int egalax_ts_probe(struct i2c_client *client,
int error;

ts = devm_kzalloc(&client->dev, sizeof(struct egalax_ts), GFP_KERNEL);
- if (!ts) {
- dev_err(&client->dev, "Failed to allocate memory\n");
+ if (!ts)
return -ENOMEM;
- }

input_dev = devm_input_allocate_device(&client->dev);
if (!input_dev) {
--
2.16.0

2018-01-21 18:53:20

by SF Markus Elfring

Subject: [PATCH 2/2] Input: egalax_ts: Improve a size determination in egalax_ts_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 21 Jan 2018 19:40:30 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/touchscreen/egalax_ts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index 29ec1166626d..da8b46ee2c1c 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -171,7 +171,7 @@ static int egalax_ts_probe(struct i2c_client *client,
struct input_dev *input_dev;
int error;

- ts = devm_kzalloc(&client->dev, sizeof(struct egalax_ts), GFP_KERNEL);
+ ts = devm_kzalloc(&client->dev, sizeof(*ts), GFP_KERNEL);
if (!ts)
return -ENOMEM;

--
2.16.0