Update the documentation to add the Caninos Loucos Labrador
vendor-prefix and items that were included in the device tree files.
Signed-off-by: Matheus Castello <[email protected]>
---
Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
2 files changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..1b131ceb884a 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -24,6 +24,11 @@ properties:
- lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
- const: lemaker,guitar
- const: actions,s500
+ - items:
+ - enum:
+ - caninos,labrador-bb # Caninos Loucos Labrador Base Board
+ - const: caninos,labrador
+ - const: actions,s500
# The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
- items:
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9e67944bec9c..3e974dd563cf 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@ patternProperties:
description: Calxeda
"^capella,.*":
description: Capella Microsystems, Inc
+ "^caninos,.*":
+ description: Caninos Loucos LSI-TEC NPO
"^cascoda,.*":
description: Cascoda, Ltd.
"^catalyst,.*":
--
2.25.0
On Thu, Feb 27, 2020 at 05:15:56PM -0300, Matheus Castello wrote:
> Update the documentation to add the Caninos Loucos Labrador
> vendor-prefix and items that were included in the device tree files.
>
These two should be splitted into separate patches.
Thanks,
Mani
> Signed-off-by: Matheus Castello <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..1b131ceb884a 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -24,6 +24,11 @@ properties:
> - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
> - const: lemaker,guitar
> - const: actions,s500
> + - items:
> + - enum:
> + - caninos,labrador-bb # Caninos Loucos Labrador Base Board
> + - const: caninos,labrador
> + - const: actions,s500
>
> # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
> - items:
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..3e974dd563cf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -167,6 +167,8 @@ patternProperties:
> description: Calxeda
> "^capella,.*":
> description: Capella Microsystems, Inc
> + "^caninos,.*":
> + description: Caninos Loucos LSI-TEC NPO
> "^cascoda,.*":
> description: Cascoda, Ltd.
> "^catalyst,.*":
> --
> 2.25.0
>
Thanks Mani for your time reviewing it.
Changes since v1:
(Suggested by Manivannan Sadhasivam)
- Sort the entries alphabetically on Makefile
- Add title comment to the base board dts
- Remove the dt-bindings/leds/common.h (garbage from tests, sorry about that)
- Split the vendor-prefix and documentation in two patches
Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.
The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.
This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.
Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.
BR,
Matheus Castello
Matheus Castello (3):
dt-bindings: Add vendor prefix for Caninos Loucos
dt-bindings: arm: actions: Document Caninos Loucos Labrador
ARM: dts: Add Caninos Loucos Labrador
.../devicetree/bindings/arm/actions.yaml | 5 +++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 ++++++++++++
5 files changed, 63 insertions(+)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
--
2.25.0
The Caninos Loucos Program develops Single Board Computers with an open
structure. The Program wants to form a community of developers to use
the IoT technology and disseminate the learning of embedded systems in
Brazil.
The boards are designed and manufactured by LSI-TEC NPO.
Signed-off-by: Matheus Castello <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 9e67944bec9c..3e974dd563cf 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@ patternProperties:
description: Calxeda
"^capella,.*":
description: Capella Microsystems, Inc
+ "^caninos,.*":
+ description: Caninos Loucos LSI-TEC NPO
"^cascoda,.*":
description: Cascoda, Ltd.
"^catalyst,.*":
--
2.25.0
Update the documentation to add the Caninos Loucos Labrador. Labrador
project consists of a computer on module based on the Actions Semi S500
processor and the Labrador base board.
Signed-off-by: Matheus Castello <[email protected]>
---
Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..1b131ceb884a 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -24,6 +24,11 @@ properties:
- lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
- const: lemaker,guitar
- const: actions,s500
+ - items:
+ - enum:
+ - caninos,labrador-bb # Caninos Loucos Labrador Base Board
+ - const: caninos,labrador
+ - const: actions,s500
# The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
- items:
--
2.25.0
Add Device Trees for Caninos Loucos Labrador CoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.
Signed-off-by: Matheus Castello <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
3 files changed, 56 insertions(+)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d6546d2676b9..99f633460833 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
dtb-$(CONFIG_ARCH_ACTIONS) += \
owl-s500-cubieboard6.dtb \
owl-s500-guitar-bb-rev-b.dtb \
+ owl-s500-labrador-bb.dtb \
owl-s500-sparky.dtb
dtb-$(CONFIG_ARCH_PRIMA2) += \
prima2-evb.dtb
diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
new file mode 100644
index 000000000000..91012b4a4c30
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador Base Board
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+
+/ {
+ compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
+ model = "Caninos Labrador Base Board M v1.0";
+
+ aliases {
+ serial3 = &uart3;
+ };
+
+ chosen {
+ stdout-path = "serial3:115200n8";
+ };
+
+ uart3_clk: uart3-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <921600>;
+ #clock-cells = <0>;
+ };
+};
+
+&uart3 {
+ status = "okay";
+ clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..0b54f1ef3ec0
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador CoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+ compatible = "caninos,labrador", "actions,s500";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x80000000>;
+ };
+};
+
+&timer {
+ clocks = <&hosc>;
+};
--
2.25.0
Hi Matheus,
Am 07.03.20 um 01:24 schrieb Matheus Castello:
> The Caninos Loucos Program develops Single Board Computers with an open
> structure. The Program wants to form a community of developers to use
> the IoT technology and disseminate the learning of embedded systems in
I would suggest "IoT technologies" without "the".
> Brazil.
>
> The boards are designed and manufactured by LSI-TEC NPO.
>
> Signed-off-by: Matheus Castello <[email protected]>
> ---
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 9e67944bec9c..3e974dd563cf 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -167,6 +167,8 @@ patternProperties:
> description: Calxeda
> "^capella,.*":
> description: Capella Microsystems, Inc
> + "^caninos,.*":
> + description: Caninos Loucos LSI-TEC NPO
Alphabetical order: n goes before p.
I'm confused by the description... Either this Caninos Loucos is an
independent vendor and gets its own prefix, or it's LSI-Tec and uses
something like lsi-tec,caninosloucos-foo. Please clarify commit message
and/or description line, at least by inserting something like "program
by", "brand by" or the like rather than just concatenating names. Maybe
compare UDOO by SECO. Is caninos,foo unique enough or should it be
caninosloucos,foo? (crazy canines?)
Note that I usually attempt to CC the organizations I'm assigning a
vendor prefix for. Do you represent them or coordinated with them?
Regards,
Andreas
> "^cascoda,.*":
> description: Cascoda, Ltd.
> "^catalyst,.*":
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
Hi Andreas,
Em 3/7/20 9:34 AM, Andreas Färber escreveu:
> Hi Matheus,
>
> Am 07.03.20 um 01:24 schrieb Matheus Castello:
>> The Caninos Loucos Program develops Single Board Computers with an open
>> structure. The Program wants to form a community of developers to use
>> the IoT technology and disseminate the learning of embedded systems in
>
> I would suggest "IoT technologies" without "the".
>
ack
>> Brazil.
>>
>> The boards are designed and manufactured by LSI-TEC NPO.
>>
>> Signed-off-by: Matheus Castello <[email protected]>
>> ---
>> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> index 9e67944bec9c..3e974dd563cf 100644
>> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
>> @@ -167,6 +167,8 @@ patternProperties:
>> description: Calxeda
>> "^capella,.*":
>> description: Capella Microsystems, Inc
>> + "^caninos,.*":
>> + description: Caninos Loucos LSI-TEC NPO
>
I will change this to "Caninos Loucos Program"
> Alphabetical order: n goes before p.
>
> I'm confused by the description... Either this Caninos Loucos is an
> independent vendor and gets its own prefix, or it's LSI-Tec and uses
> something like lsi-tec,caninosloucos-foo. Please clarify commit message
> and/or description line, at least by inserting something like "program
> by", "brand by" or the like rather than just concatenating names. Maybe
> compare UDOO by SECO. Is caninos,foo unique enough or should it be
> caninosloucos,foo? (crazy canines?)
>
Yes "Caninos Loucos" means crazy canines (or mad dog) in Portuguese.
This is a initiative that have as co-founder the Jon Maddog Hall,
because of Jon we have the "maddog", but in Portuguese, on the name of
program.
From their website: https://caninosloucos.org/en/program-en/:
"It is an initiative of the Technological Integrated Systems Laboratory
(LSI-TEC) with the support of Polytechnic School of the University of
São Paulo (Poli-USP) and Jon “Maddog” Hall"
So I think we can put this instead "The boards are designed and
manufactured by LSI-TEC NPO." on description.
Let me know what you think about this.
> Note that I usually attempt to CC the organizations I'm assigning a
> vendor prefix for. Do you represent them or coordinated with them?
>
Thanks for the review and tips. I am adding Edgar Bernardi Righi and
Igor Ruschi from Caninos team as CC on this patch series.
Best Regards,
Matheus Castello
> Regards,
> Andreas
>
>> "^cascoda,.*":
>> description: Cascoda, Ltd.
>> "^catalyst,.*":
>
Thanks Andreas and Mani for your time reviewing it.
Changes since v2:
(Suggested by Andreas Färber)
- Sort the entries alphabetically on vendor-prefixes.yaml
- Improve commit description
- Add Edgar Bernardi Righi and Igor Ruschi from Caninos team as CC
Changes since v1:
(Suggested by Manivannan Sadhasivam)
- Sort the entries alphabetically on Makefile
- Add title comment to the base board dts
- Remove the dt-bindings/leds/common.h (garbage from tests, sorry about that)
- Split the vendor-prefix and documentation in two patches
Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.
The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.
This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.
Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.
Stay safe,
Matheus Castello
Matheus Castello (3):
dt-bindings: Add vendor prefix for Caninos Loucos
dt-bindings: arm: actions: Document Caninos Loucos Labrador
ARM: dts: Add Caninos Loucos Labrador
.../devicetree/bindings/arm/actions.yaml | 5 +++
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 ++++++++++++
5 files changed, 63 insertions(+)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
--
2.25.0
Update the documentation to add the Caninos Loucos Labrador. Labrador
project consists of a computer on module based on the Actions Semi S500
processor and the Labrador base board.
Signed-off-by: Matheus Castello <[email protected]>
---
Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
index ace3fdaa8396..1b131ceb884a 100644
--- a/Documentation/devicetree/bindings/arm/actions.yaml
+++ b/Documentation/devicetree/bindings/arm/actions.yaml
@@ -24,6 +24,11 @@ properties:
- lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
- const: lemaker,guitar
- const: actions,s500
+ - items:
+ - enum:
+ - caninos,labrador-bb # Caninos Loucos Labrador Base Board
+ - const: caninos,labrador
+ - const: actions,s500
# The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
- items:
--
2.25.0
Add Device Trees for Caninos Loucos Labrador CoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.
Signed-off-by: Matheus Castello <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
3 files changed, 56 insertions(+)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index d6546d2676b9..99f633460833 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
dtb-$(CONFIG_ARCH_ACTIONS) += \
owl-s500-cubieboard6.dtb \
owl-s500-guitar-bb-rev-b.dtb \
+ owl-s500-labrador-bb.dtb \
owl-s500-sparky.dtb
dtb-$(CONFIG_ARCH_PRIMA2) += \
prima2-evb.dtb
diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
new file mode 100644
index 000000000000..91012b4a4c30
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador Base Board
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+
+/ {
+ compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
+ model = "Caninos Labrador Base Board M v1.0";
+
+ aliases {
+ serial3 = &uart3;
+ };
+
+ chosen {
+ stdout-path = "serial3:115200n8";
+ };
+
+ uart3_clk: uart3-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <921600>;
+ #clock-cells = <0>;
+ };
+};
+
+&uart3 {
+ status = "okay";
+ clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..0b54f1ef3ec0
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador CoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+ compatible = "caninos,labrador", "actions,s500";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x80000000>;
+ };
+};
+
+&timer {
+ clocks = <&hosc>;
+};
--
2.25.0
On Fri, 20 Mar 2020 00:51:03 -0300, Matheus Castello wrote:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
>
> Signed-off-by: Matheus Castello <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
> Add Device Trees for Caninos Loucos Labrador CoM and base board.
> Based on the work of Andreas F?rber on Lemaker Guitar device tree.
>
> Signed-off-by: Matheus Castello <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Will queue the series for v5.8 once Andreas is happy with it.
Nit: Please keep [email protected] in CC for all future
patches/replies.
Thanks,
Mani
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++
> arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
> 3 files changed, 56 insertions(+)
> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d6546d2676b9..99f633460833 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
> dtb-$(CONFIG_ARCH_ACTIONS) += \
> owl-s500-cubieboard6.dtb \
> owl-s500-guitar-bb-rev-b.dtb \
> + owl-s500-labrador-bb.dtb \
> owl-s500-sparky.dtb
> dtb-$(CONFIG_ARCH_PRIMA2) += \
> prima2-evb.dtb
> diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
> new file mode 100644
> index 000000000000..91012b4a4c30
> --- /dev/null
> +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Caninos Labrador Base Board
> + *
> + * Copyright (c) 2019-2020 Matheus Castello
> + */
> +
> +/dts-v1/;
> +
> +#include "owl-s500-labrador-v2.dtsi"
> +
> +/ {
> + compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
> + model = "Caninos Labrador Base Board M v1.0";
> +
> + aliases {
> + serial3 = &uart3;
> + };
> +
> + chosen {
> + stdout-path = "serial3:115200n8";
> + };
> +
> + uart3_clk: uart3-clk {
> + compatible = "fixed-clock";
> + clock-frequency = <921600>;
> + #clock-cells = <0>;
> + };
> +};
> +
> +&uart3 {
> + status = "okay";
> + clocks = <&uart3_clk>;
> +};
> diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
> new file mode 100644
> index 000000000000..0b54f1ef3ec0
> --- /dev/null
> +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
> @@ -0,0 +1,21 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Caninos Labrador CoM V2
> + *
> + * Copyright (c) 2019-2020 Matheus Castello
> + */
> +
> +#include "owl-s500.dtsi"
> +
> +/ {
> + compatible = "caninos,labrador", "actions,s500";
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x0 0x80000000>;
> + };
> +};
> +
> +&timer {
> + clocks = <&hosc>;
> +};
> --
> 2.25.0
>
Hi Andreas,
Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>
>> Signed-off-by: Matheus Castello <[email protected]>
>
> Reviewed-by: Manivannan Sadhasivam <[email protected]>
>
> Will queue the series for v5.8 once Andreas is happy with it.
>
do you have any more concerns about these patches? Let me know.
BR,
Matheus Castello
> Nit: Please keep [email protected] in CC for all future
> patches/replies.
>
> Thanks,
> Mani
>
>> ---
>> arch/arm/boot/dts/Makefile | 1 +
>> arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++
>> arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++
>> 3 files changed, 56 insertions(+)
>> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts
>> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index d6546d2676b9..99f633460833 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
>> dtb-$(CONFIG_ARCH_ACTIONS) += \
>> owl-s500-cubieboard6.dtb \
>> owl-s500-guitar-bb-rev-b.dtb \
>> + owl-s500-labrador-bb.dtb \
>> owl-s500-sparky.dtb
>> dtb-$(CONFIG_ARCH_PRIMA2) += \
>> prima2-evb.dtb
>> diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
>> new file mode 100644
>> index 000000000000..91012b4a4c30
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts
>> @@ -0,0 +1,34 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Caninos Labrador Base Board
>> + *
>> + * Copyright (c) 2019-2020 Matheus Castello
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "owl-s500-labrador-v2.dtsi"
>> +
>> +/ {
>> + compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500";
>> + model = "Caninos Labrador Base Board M v1.0";
>> +
>> + aliases {
>> + serial3 = &uart3;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial3:115200n8";
>> + };
>> +
>> + uart3_clk: uart3-clk {
>> + compatible = "fixed-clock";
>> + clock-frequency = <921600>;
>> + #clock-cells = <0>;
>> + };
>> +};
>> +
>> +&uart3 {
>> + status = "okay";
>> + clocks = <&uart3_clk>;
>> +};
>> diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>> new file mode 100644
>> index 000000000000..0b54f1ef3ec0
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
>> @@ -0,0 +1,21 @@
>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> +/*
>> + * Caninos Labrador CoM V2
>> + *
>> + * Copyright (c) 2019-2020 Matheus Castello
>> + */
>> +
>> +#include "owl-s500.dtsi"
>> +
>> +/ {
>> + compatible = "caninos,labrador", "actions,s500";
>> +
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x0 0x80000000>;
>> + };
>> +};
>> +
>> +&timer {
>> + clocks = <&hosc>;
>> +};
>> --
>> 2.25.0
>>
+ linux-actions
Am 20.03.20 um 04:51 schrieb Matheus Castello:
> Update the documentation to add the Caninos Loucos Labrador. Labrador
> project consists of a computer on module based on the Actions Semi S500
> processor and the Labrador base board.
>
> Signed-off-by: Matheus Castello <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/actions.yaml b/Documentation/devicetree/bindings/arm/actions.yaml
> index ace3fdaa8396..1b131ceb884a 100644
> --- a/Documentation/devicetree/bindings/arm/actions.yaml
> +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> @@ -24,6 +24,11 @@ properties:
> - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board rev. B
> - const: lemaker,guitar
> - const: actions,s500
> + - items:
> + - enum:
> + - caninos,labrador-bb # Caninos Loucos Labrador Base Board
> + - const: caninos,labrador
> + - const: actions,s500
>
> # The Actions Semi S700 is a quad-core ARM Cortex-A53 SoC.
> - items:
Now that you chose to stick with caninos rather than lsi prefix, the
sort order compared to lemaker remains wrong.
Looking at https://caninosloucos.org/en/labrador-en/ there's a "CORE
BOARD V2.0" and a "BASE BOARD M V1.0".
Assuming the v2 is not software-relevant, shouldn't the M be reflected
in the compatible string? For example, "caninos,labrador-core" and
"caninos,labrador-m"? You're free to use -bb-m of course, but no need to
copy LeMaker -bb naming for your board. What does your PCB say?
Also note that other recent bindings have been using a description
attribute - not sure whether we can apply that a) to the SoM and b) to
the base board here. Please compare other in-tree bindings.
Regards,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
Hi Matheus,
Am 23.04.20 um 17:20 schrieb Matheus Castello:
> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>>
>>> Signed-off-by: Matheus Castello <[email protected]>
>>
>> Reviewed-by: Manivannan Sadhasivam <[email protected]>
>>
>> Will queue the series for v5.8 once Andreas is happy with it.
>
> do you have any more concerns about these patches? Let me know.
I've reviewed the preceding two patches. This one here looks okay,
Reviewed-by: Andreas Färber <[email protected]>
but see 2/3 - model here does contain M and your .dtsi is named -v2 -
what's the difference to v1? If it's big enough to warrant a separate
.dtsi, you should consider whether a versioned compatible string may be
needed, too (likely in addition to, not instead of a generic one). No v1
info on the website.
Thanks,
Andreas
--
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
Hi Andreas,
thanks for the review.
Em 4/26/20 8:58 AM, Andreas Färber escreveu:
> Hi Matheus,
>
> Am 23.04.20 um 17:20 schrieb Matheus Castello:
>> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu:
>>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote:
>>>> Add Device Trees for Caninos Loucos Labrador CoM and base board.
>>>> Based on the work of Andreas Färber on Lemaker Guitar device tree.
>>>>
>>>> Signed-off-by: Matheus Castello <[email protected]>
>>>
>>> Reviewed-by: Manivannan Sadhasivam <[email protected]>
>>>
>>> Will queue the series for v5.8 once Andreas is happy with it.
>>
>> do you have any more concerns about these patches? Let me know.
>
> I've reviewed the preceding two patches. This one here looks okay,
>
> Reviewed-by: Andreas Färber <[email protected]>
>
> but see 2/3 - model here does contain M and your .dtsi is named -v2 -
> what's the difference to v1? If it's big enough to warrant a separate
> .dtsi, you should consider whether a versioned compatible string may be
> needed, too (likely in addition to, not instead of a generic one). No v1
> info on the website.
>
The difference between v1 and v2 is the model and vendor of the DRAM and
storage eMMC. But that had no impact on the software.
Checking examples on "/Documentation/devicetree/bindings/arm/" I saw
that some add enum descriptions for both the base board and system on
module, keeping in const only the vendor prefix of the SoC. And in the
device tree both have the model property description. I liked this
example, I think I will follow it in v4.
About "-bb-" in the file name and description: on PCB is written
"Labrador Base-M v1.0a", so with that I think it is better to leave only
base on the name.
I will send the v4, thank you very much for the review.
BR,
Matheus Castello
> Thanks,
> Andreas
>
Thanks Andreas, Mani and Rob for your time reviewing it.
Changes since v3:
(Suggested by Andreas Färber)
- Fix sort on actions.yaml
- Change the file owl-s500-labrador-bb.dts to owl-s500-labrador-base-m.dts
- Add description for both the SoM and Base Board
- Add Model description for both the SoM and Base Board
Changes since v2:
(Suggested by Andreas Färber)
- Sort the entries alphabetically on vendor-prefixes.yaml
- Improve commit description
- Add Edgar Bernardi Righi and Igor Ruschi from Caninos team as CC
Caninos Loucos Labrador is a Brazilian project of open System on Modules and
Base Boards based on Lemaker Guitar. Is an initiative of LSI-TEC a non-profit
organization.
The Labrador CoM v2 is based on Actions Semi S500 processor with 16GB eMMC and
2GB RAM.
This series adds the initial work for device tree files and also adds the
vendor-prefix for the Caninos program. The work was based on the Andreas Färber
device trees for Lemaker Guitar, thanks Andreas.
Tested on my Caninos Labrador v2, only earlycon serial output is available for
now, using the fake clock. I have already worked on something here to add the
clocks and pinctrl nodes to owl-s500.dtsi, but I would like to first add the
initial device tree files and then work on the other patches calmly.
Stay safe,
Matheus Castello
Matheus Castello (3):
dt-bindings: Add vendor prefix for Caninos Loucos
dt-bindings: arm: actions: Document Caninos Loucos Labrador
ARM: dts: Add Caninos Loucos Labrador
.../devicetree/bindings/arm/actions.yaml | 11 ++++--
.../devicetree/bindings/vendor-prefixes.yaml | 2 ++
arch/arm/boot/dts/Makefile | 1 +
.../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 22 ++++++++++++
5 files changed, 67 insertions(+), 3 deletions(-)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
--
2.25.0
Add Device Trees for Caninos Loucos Labrador CoM and base board.
Based on the work of Andreas Färber on Lemaker Guitar device tree.
Signed-off-by: Matheus Castello <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
---
arch/arm/boot/dts/Makefile | 1 +
.../arm/boot/dts/owl-s500-labrador-base-m.dts | 34 +++++++++++++++++++
arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 22 ++++++++++++
3 files changed, 57 insertions(+)
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-base-m.dts
create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index e8dd99201397..02a619d7bf2e 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -856,6 +856,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \
dtb-$(CONFIG_ARCH_ACTIONS) += \
owl-s500-cubieboard6.dtb \
owl-s500-guitar-bb-rev-b.dtb \
+ owl-s500-labrador-base-m.dtb \
owl-s500-sparky.dtb
dtb-$(CONFIG_ARCH_PRIMA2) += \
prima2-evb.dtb
diff --git a/arch/arm/boot/dts/owl-s500-labrador-base-m.dts b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
new file mode 100644
index 000000000000..044568fec25e
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-base-m.dts
@@ -0,0 +1,34 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador Base Board
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+/dts-v1/;
+
+#include "owl-s500-labrador-v2.dtsi"
+
+/ {
+ model = "Caninos Labrador Base-M v1.0a";
+ compatible = "caninos,labrador-base-m", "actions,s500";
+
+ aliases {
+ serial3 = &uart3;
+ };
+
+ chosen {
+ stdout-path = "serial3:115200n8";
+ };
+
+ uart3_clk: uart3-clk {
+ compatible = "fixed-clock";
+ clock-frequency = <921600>;
+ #clock-cells = <0>;
+ };
+};
+
+&uart3 {
+ status = "okay";
+ clocks = <&uart3_clk>;
+};
diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
new file mode 100644
index 000000000000..f31def6b248a
--- /dev/null
+++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi
@@ -0,0 +1,22 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Caninos Labrador SoM V2
+ *
+ * Copyright (c) 2019-2020 Matheus Castello
+ */
+
+#include "owl-s500.dtsi"
+
+/ {
+ model = "Caninos Labrador Core V2.1";
+ compatible = "caninos,labrador-v2", "actions,s500";
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x80000000>;
+ };
+};
+
+&timer {
+ clocks = <&hosc>;
+};
--
2.25.0
The Caninos Loucos Program develops Single Board Computers with an open
structure. The Program wants to form a community of developers to use
IoT technologies and disseminate the learning of embedded systems in
Brazil.
It is an initiative of the Technological Integrated Systems Laboratory
(LSI-TEC) with the support of Polytechnic School of the University of
São Paulo (Poli-USP) and Jon "Maddog" Hall.
Signed-off-by: Matheus Castello <[email protected]>
Acked-by: Rob Herring <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..a20a05e3deaa 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -167,6 +167,8 @@ patternProperties:
description: CALAO Systems SAS
"^calxeda,.*":
description: Calxeda
+ "^caninos,.*":
+ description: Caninos Loucos Program
"^capella,.*":
description: Capella Microsystems, Inc
"^cascoda,.*":
--
2.25.0