2020-06-17 01:43:03

by Sowjanya Komatineni

Subject: [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based

Tegra CSI driver need a separate MIPI device for each channel as
calibration of corresponding MIPI pads for each channel should
happen independently.

So, this patch updates tegra_mipi_request() API to add a device_node
pointer argument to allow creating mipi device for specific device
node rather than a device.

Signed-off-by: Sowjanya Komatineni <[email protected]>
---
drivers/gpu/drm/tegra/dsi.c | 2 +-
drivers/gpu/host1x/mipi.c | 7 +++++--
include/linux/host1x.h | 3 ++-
3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
index 38beab9..0443589 100644
--- a/drivers/gpu/drm/tegra/dsi.c
+++ b/drivers/gpu/drm/tegra/dsi.c
@@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev)
if (IS_ERR(dsi->regs))
return PTR_ERR(dsi->regs);

- dsi->mipi = tegra_mipi_request(&pdev->dev);
+ dsi->mipi = tegra_mipi_request(&pdev->dev, NULL);
if (IS_ERR(dsi->mipi))
return PTR_ERR(dsi->mipi);

diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
index e00809d..93b354b 100644
--- a/drivers/gpu/host1x/mipi.c
+++ b/drivers/gpu/host1x/mipi.c
@@ -206,13 +206,16 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi)
return 0;
}

-struct tegra_mipi_device *tegra_mipi_request(struct device *device)
+struct tegra_mipi_device *tegra_mipi_request(struct device *device,
+ struct device_node *np)
{
- struct device_node *np = device->of_node;
struct tegra_mipi_device *dev;
struct of_phandle_args args;
int err;

+ if (!np)
+ np = device->of_node;
+
err = of_parse_phandle_with_args(np, "nvidia,mipi-calibrate",
"#nvidia,mipi-calibrate-cells", 0,
&args);
diff --git a/include/linux/host1x.h b/include/linux/host1x.h
index c230b4e..61dc577 100644
--- a/include/linux/host1x.h
+++ b/include/linux/host1x.h
@@ -325,7 +325,8 @@ int host1x_client_resume(struct host1x_client *client);

struct tegra_mipi_device;

-struct tegra_mipi_device *tegra_mipi_request(struct device *device);
+struct tegra_mipi_device *tegra_mipi_request(struct device *device,
+ struct device_node *np);
void tegra_mipi_free(struct tegra_mipi_device *device);
int tegra_mipi_enable(struct tegra_mipi_device *device);
int tegra_mipi_disable(struct tegra_mipi_device *device);
--
2.7.4

2020-06-18 00:30:04

by Dmitry Osipenko

Subject: Re: [RFC PATCH v2 13/18] gpu: host1x: mipi: Update tegra_mipi_request() to be node based

17.06.2020 04:41, Sowjanya Komatineni пишет:
> Tegra CSI driver need a separate MIPI device for each channel as
> calibration of corresponding MIPI pads for each channel should
> happen independently.
>
> So, this patch updates tegra_mipi_request() API to add a device_node
> pointer argument to allow creating mipi device for specific device
> node rather than a device.
>
> Signed-off-by: Sowjanya Komatineni <[email protected]>
> ---
> drivers/gpu/drm/tegra/dsi.c | 2 +-
> drivers/gpu/host1x/mipi.c | 7 +++++--
> include/linux/host1x.h | 3 ++-
> 3 files changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c
> index 38beab9..0443589 100644
> --- a/drivers/gpu/drm/tegra/dsi.c
> +++ b/drivers/gpu/drm/tegra/dsi.c
> @@ -1618,7 +1618,7 @@ static int tegra_dsi_probe(struct platform_device *pdev)
> if (IS_ERR(dsi->regs))
> return PTR_ERR(dsi->regs);
>
> - dsi->mipi = tegra_mipi_request(&pdev->dev);
> + dsi->mipi = tegra_mipi_request(&pdev->dev, NULL);
> if (IS_ERR(dsi->mipi))
> return PTR_ERR(dsi->mipi);
>
> diff --git a/drivers/gpu/host1x/mipi.c b/drivers/gpu/host1x/mipi.c
> index e00809d..93b354b 100644
> --- a/drivers/gpu/host1x/mipi.c
> +++ b/drivers/gpu/host1x/mipi.c
> @@ -206,13 +206,16 @@ static int tegra_mipi_power_down(struct tegra_mipi *mipi)
> return 0;
> }
>
> -struct tegra_mipi_device *tegra_mipi_request(struct device *device)
> +struct tegra_mipi_device *tegra_mipi_request(struct device *device,
> + struct device_node *np)
> {
> - struct device_node *np = device->of_node;
> struct tegra_mipi_device *dev;
> struct of_phandle_args args;
> int err;
>
> + if (!np)
> + np = device->of_node;

Will be nicer if DSI panel could pass the device's node directly,
instead of this.