2023-11-22 17:12:58

by Jeremi Piotrowski

[permalink] [raw]
Subject: Re: [PATCH] x86/mm: Check cc_vendor when printing memory encryption info

On 10/11/2023 19:57, [email protected] wrote:
> On Fri, Nov 10, 2023 at 02:42:31PM +0100, Jeremi Piotrowski wrote:
>> On 10/11/2023 13:46, [email protected] wrote:
>>> On Fri, Nov 10, 2023 at 01:27:08PM +0100, Jeremi Piotrowski wrote:
>>>>> Maybe just remove incorrect info and that's it?
>>>>>
>>>>
>>>> I disagree, other users and I find the print very useful to see which coco
>>>> platform the kernel is running on and which confidential computing features
>>>> the kernel detected. I'm willing to fix the code to report correct info.
>>>
>>> For TDX, we already have "tdx: Guest detected" in dmesg. sme_early_init()
>>> can do something similar.
>>>
>>
>> That doesn't cover TDX guests with TD partitioning on Hyper-V.
>
> I am sure Hyper-V can report what mode it runs.
>

You're right, it could. In that case I would move the AMD print and keep only
"Memory Encryption is active" here.

Lets see whether we find agreement on my new submission first.

Thanks,
Jeremi