This series enables support for the SPI NOR on the
imx8mp based phyboard-pollux-rdk board.
Patches new in v2:
"spi: fspi: enable fspi driver for on imx8mp"
which adds own compatible entry for imx8mp
and seperate in own patch the documentation entry in
patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
as checkpatch says:
warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
Changes in v2:
- work in comments from Marco
add own compatible entry for imx8mp
- work in comments from Marco
- add own compatible entry "nxp,imx8mp-fspi"
- reworked order of properties as Marco mentioned
- work in comments from Marco and Teresa
- rename node into "'som_flash: flash@0 { }"
- compatible is now first entry
- removed #size-cells and #address-cells
as no child node. If bootloader adds them bootloader
can add them too.
Heiko Schocher (4):
spi: fspi: enable fspi driver for on imx8mp
dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
controller
arm64: dts: imx8mp: add flexspi node
arm64: imx8mp: imx8mp-phycore-som enable spi nor
.../devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
.../dts/freescale/imx8mp-phycore-som.dtsi | 25 +++++++++++++++++++
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++
drivers/spi/spi-nxp-fspi.c | 1 +
4 files changed, 43 insertions(+)
--
2.29.2
add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
Signed-off-by: Heiko Schocher <[email protected]>
---
(no changes since v1)
Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
index 7ac60d9fe3571..fd5f081f6d91b 100644
--- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
+++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
@@ -4,6 +4,7 @@ Required properties:
- compatible : Should be "nxp,lx2160a-fspi"
"nxp,imx8qxp-fspi"
"nxp,imx8mm-fspi"
+ "nxp,imx8mp-fspi"
- reg : First contains the register location and length,
Second contains the memory mapping address and length
--
2.29.2
add node for the flexspi modul on imx8mp.
Signed-off-by: Heiko Schocher <[email protected]>
---
Changes in v2:
- work in comments from Marco
- add own compatible entry "nxp,imx8mp-fspi"
- reworked order of properties as Marco mentioned
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index c7523fd4eae9b..18023d97235ed 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -36,6 +36,7 @@ aliases {
serial1 = &uart2;
serial2 = &uart3;
serial3 = &uart4;
+ spi0 = &flexspi;
};
cpus {
@@ -744,6 +745,21 @@ usdhc3: mmc@30b60000 {
status = "disabled";
};
+ flexspi: spi@30bb0000 {
+ compatible = "nxp,imx8mp-fspi";
+ reg = <0x30bb0000 0x10000>, <0x8000000 0x10000000>;
+ reg-names = "fspi_base", "fspi_mmap";
+ interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MP_CLK_QSPI_ROOT>,
+ <&clk IMX8MP_CLK_QSPI_ROOT>;
+ clock-names = "fspi", "fspi_en";
+ assigned-clock-rates = <80000000>;
+ assigned-clocks = <&clk IMX8MP_CLK_QSPI>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
sdma1: dma-controller@30bd0000 {
compatible = "fsl,imx8mp-sdma", "fsl,imx8mq-sdma";
reg = <0x30bd0000 0x10000>;
--
2.29.2
enable the mt25qu256aba spi nor on the imx8mp-phycore-som.
Signed-off-by: Heiko Schocher <[email protected]>
---
Changes in v2:
- work in comments from Marco and Teresa
- rename node into "'som_flash: flash@0 { }"
- compatible is now first entry
- removed #size-cells and #address-cells
as no child node. If bootloader adds them bootloader
can add them too.
.../dts/freescale/imx8mp-phycore-som.dtsi | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
index 44a8c2337cee4..e648b1b6acdaa 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
@@ -65,6 +65,20 @@ ethphy1: ethernet-phy@0 {
};
};
+&flexspi {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_flexspi0>;
+ status = "okay";
+
+ som_flash: flash@0 {
+ compatible = "jedec,spi-nor";
+ reg = <0>;
+ spi-max-frequency = <80000000>;
+ spi-tx-bus-width = <4>;
+ spi-rx-bus-width = <4>;
+ };
+};
+
&i2c1 {
clock-frequency = <400000>;
pinctrl-names = "default";
@@ -217,6 +231,17 @@ MX8MP_IOMUXC_GPIO1_IO15__GPIO1_IO15 0x11
>;
};
+ pinctrl_flexspi0: flexspi0grp {
+ fsl,pins = <
+ MX8MP_IOMUXC_NAND_ALE__FLEXSPI_A_SCLK 0x1c2
+ MX8MP_IOMUXC_NAND_CE0_B__FLEXSPI_A_SS0_B 0x82
+ MX8MP_IOMUXC_NAND_DATA00__FLEXSPI_A_DATA00 0x82
+ MX8MP_IOMUXC_NAND_DATA01__FLEXSPI_A_DATA01 0x82
+ MX8MP_IOMUXC_NAND_DATA02__FLEXSPI_A_DATA02 0x82
+ MX8MP_IOMUXC_NAND_DATA03__FLEXSPI_A_DATA03 0x82
+ >;
+ };
+
pinctrl_i2c1: i2c1grp {
fsl,pins = <
MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL 0x400001c3
--
2.29.2
add compatible entry in nxp_fspi driver for imx8mp.
Signed-off-by: Heiko Schocher <[email protected]>
---
Changes in v2:
- work in comments from Marco
add own compatible entry for imx8mp
drivers/spi/spi-nxp-fspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index ab9035662717a..19ce4a854cc97 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -1151,6 +1151,7 @@ static int nxp_fspi_resume(struct device *dev)
static const struct of_device_id nxp_fspi_dt_ids[] = {
{ .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, },
{ .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, },
+ { .compatible = "nxp,imx8mp-fspi", .data = (void *)&imx8mm_data, },
{ .compatible = "nxp,imx8qxp-fspi", .data = (void *)&imx8qxp_data, },
{ /* sentinel */ }
};
--
2.29.2
Hi Heiko,
> -----Original Message-----
> From: Heiko Schocher <[email protected]>
> Sent: Tuesday, March 9, 2021 11:01 AM
> To: [email protected]
> Cc: Heiko Schocher <[email protected]>; Ashish Kumar <[email protected]>;
> Mark Brown <[email protected]>; Rob Herring <[email protected]>; Yogesh
> Gaur <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in
> FlexSPI controller
>
> Caution: EXT Email
>
> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>
> Signed-off-by: Heiko Schocher <[email protected]>
> ---
>
> (no changes since v1)
>
> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> index 7ac60d9fe3571..fd5f081f6d91b 100644
> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> @@ -4,6 +4,7 @@ Required properties:
> - compatible : Should be "nxp,lx2160a-fspi"
> "nxp,imx8qxp-fspi"
> "nxp,imx8mm-fspi"
> + "nxp,imx8mp-fspi"
It seems the changes are not on top of tree. Please see[1] for latest changes including imx8dxl entry.
Snippet below:
Required properties:
- compatible : Should be "nxp,lx2160a-fspi"
"nxp,imx8qxp-fspi"
"nxp,imx8mm-fspi"
"nxp,imx8dxl-fspi"
Thanks
Kuldeep
[1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
Hi!
On 09.03.21 06:56, Kuldeep Singh wrote:
> Hi Heiko,
>
>> -----Original Message-----
>> From: Heiko Schocher <[email protected]>
>> Sent: Tuesday, March 9, 2021 11:01 AM
>> To: [email protected]
>> Cc: Heiko Schocher <[email protected]>; Ashish Kumar <[email protected]>;
>> Mark Brown <[email protected]>; Rob Herring <[email protected]>; Yogesh
>> Gaur <[email protected]>; [email protected]; linux-
>> [email protected]; [email protected]
>> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry for imx8mp in
>> FlexSPI controller
>>
>> Caution: EXT Email
>>
>> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>>
>> Signed-off-by: Heiko Schocher <[email protected]>
>> ---
>>
>> (no changes since v1)
>>
>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> index 7ac60d9fe3571..fd5f081f6d91b 100644
>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>> @@ -4,6 +4,7 @@ Required properties:
>> - compatible : Should be "nxp,lx2160a-fspi"
>> "nxp,imx8qxp-fspi"
>> "nxp,imx8mm-fspi"
>> + "nxp,imx8mp-fspi"
>
> It seems the changes are not on top of tree. Please see[1] for latest changes including imx8dxl entry.
> Snippet below:
>
> Required properties:
> - compatible : Should be "nxp,lx2160a-fspi"
> "nxp,imx8qxp-fspi"
> "nxp,imx8mm-fspi"
> "nxp,imx8dxl-fspi"
My patches are based on mainline..
* 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-v5.12-2020-03-07'
of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden) <Linus Torvalds>
Should I post this patch rebased on [1] or may all patches
rebased on [1] ?
Thanks!
bye,
Heiko
>
> Thanks
> Kuldeep
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/tree/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
> Hi!
>
> On 09.03.21 06:56, Kuldeep Singh wrote:
> > Hi Heiko,
> >
> >> -----Original Message-----
> >> From: Heiko Schocher <[email protected]>
> >> Sent: Tuesday, March 9, 2021 11:01 AM
> >> To: [email protected]
> >> Cc: Heiko Schocher <[email protected]>; Ashish Kumar <[email protected]>;
> >> Mark Brown <[email protected]>; Rob Herring <[email protected]>;
> >> Yogesh Gaur <[email protected]>; [email protected];
> >> linux- [email protected]; [email protected]
> >> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry
> >> for imx8mp in FlexSPI controller
> >>
> >> Caution: EXT Email
> >>
> >> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
> >>
> >> Signed-off-by: Heiko Schocher <[email protected]>
> >> ---
> >>
> >> (no changes since v1)
> >>
> >> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> index 7ac60d9fe3571..fd5f081f6d91b 100644
> >> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> >> @@ -4,6 +4,7 @@ Required properties:
> >> - compatible : Should be "nxp,lx2160a-fspi"
> >> "nxp,imx8qxp-fspi"
> >> "nxp,imx8mm-fspi"
> >> + "nxp,imx8mp-fspi"
> >
> > It seems the changes are not on top of tree. Please see[1] for latest changes
> including imx8dxl entry.
> > Snippet below:
> >
> > Required properties:
> > - compatible : Should be "nxp,lx2160a-fspi"
> > "nxp,imx8qxp-fspi"
> > "nxp,imx8mm-fspi"
> > "nxp,imx8dxl-fspi"
>
> My patches are based on mainline..
> * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-
> v5.12-2020-03-07'
> of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden)
> <Linus Torvalds>
>
> Should I post this patch rebased on [1] or may all patches rebased on [1] ?
Hi Heiko,
As per cover letter, I can identify that first two are driver/Documentation patches and other two are device-tree patches.
Device-tree patches(3/4 and 4/4) will go via Shawn tree (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git)
And initial two driver patches(1/4 and 2/4) will go via Mark's tree (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git)
One approach I can think of is to send driver patches first and later send device-tree patches mentioning dependency on first two patches.
Maybe Mark can comment here if he has any other opinion.
Thanks
Kuldeep
Hello Kuldeep,
On 09.03.21 07:29, Kuldeep Singh wrote:
>> Hi!
>>
>> On 09.03.21 06:56, Kuldeep Singh wrote:
>>> Hi Heiko,
>>>
>>>> -----Original Message-----
>>>> From: Heiko Schocher <[email protected]>
>>>> Sent: Tuesday, March 9, 2021 11:01 AM
>>>> To: [email protected]
>>>> Cc: Heiko Schocher <[email protected]>; Ashish Kumar <[email protected]>;
>>>> Mark Brown <[email protected]>; Rob Herring <[email protected]>;
>>>> Yogesh Gaur <[email protected]>; [email protected];
>>>> linux- [email protected]; [email protected]
>>>> Subject: [EXT] [PATCH v2 2/4] dt-bindings: spi: add compatible entry
>>>> for imx8mp in FlexSPI controller
>>>>
>>>> Caution: EXT Email
>>>>
>>>> add compatible entry "nxp,imx8mp-fspi" in NXP FlexSPI controller
>>>>
>>>> Signed-off-by: Heiko Schocher <[email protected]>
>>>> ---
>>>>
>>>> (no changes since v1)
>>>>
>>>> Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> index 7ac60d9fe3571..fd5f081f6d91b 100644
>>>> --- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> +++ b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>>>> @@ -4,6 +4,7 @@ Required properties:
>>>> - compatible : Should be "nxp,lx2160a-fspi"
>>>> "nxp,imx8qxp-fspi"
>>>> "nxp,imx8mm-fspi"
>>>> + "nxp,imx8mp-fspi"
>>>
>>> It seems the changes are not on top of tree. Please see[1] for latest changes
>> including imx8dxl entry.
>>> Snippet below:
>>>
>>> Required properties:
>>> - compatible : Should be "nxp,lx2160a-fspi"
>>> "nxp,imx8qxp-fspi"
>>> "nxp,imx8mm-fspi"
>>> "nxp,imx8dxl-fspi"
>>
>> My patches are based on mainline..
>> * 144c79ef33536 - (origin/master, origin/HEAD) Merge tag 'perf-tools-fixes-for-
>> v5.12-2020-03-07'
>> of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux (vor 32 Stunden)
>> <Linus Torvalds>
>>
>> Should I post this patch rebased on [1] or may all patches rebased on [1] ?
>
> Hi Heiko,
>
> As per cover letter, I can identify that first two are driver/Documentation patches and other two are device-tree patches.
> Device-tree patches(3/4 and 4/4) will go via Shawn tree (git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git)
> And initial two driver patches(1/4 and 2/4) will go via Mark's tree (git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git)
>
> One approach I can think of is to send driver patches first and later send device-tree patches mentioning dependency on first two patches.
Yep, seems a good approach to me.
> Maybe Mark can comment here if he has any other opinion.
Yep, will wait for more comments, and if all is fine with this
patchset, I can split it into 2 series.
Thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
Hi Heiko,
On 21-03-09 06:31, Heiko Schocher wrote:
>
> This series enables support for the SPI NOR on the
> imx8mp based phyboard-pollux-rdk board.
>
> Patches new in v2:
> "spi: fspi: enable fspi driver for on imx8mp"
> which adds own compatible entry for imx8mp
>
> and seperate in own patch the documentation entry in
> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> as checkpatch says:
>
> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
Thanks for picking up the comments :) Did you missed to send them or did
you used an other Cc: and To: for the new patches?
Regards,
Marco
Hello Marco,
On 09.03.21 09:19, Marco Felsch wrote:
> Hi Heiko,
>
> On 21-03-09 06:31, Heiko Schocher wrote:
>>
>> This series enables support for the SPI NOR on the
>> imx8mp based phyboard-pollux-rdk board.
>>
>> Patches new in v2:
>> "spi: fspi: enable fspi driver for on imx8mp"
>> which adds own compatible entry for imx8mp
>>
>> and seperate in own patch the documentation entry in
>> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
>> as checkpatch says:
>>
>> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
> Thanks for picking up the comments :) Did you missed to send them or did
> you used an other Cc: and To: for the new patches?
Damn, I use patman tool from u-boot source whoch generates cc list
and missed to add you explicitely to Cc... sorry
They are all on linux-arm-kernel:
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643290.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643291.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643292.html
http://lists.infradead.org/pipermail/linux-arm-kernel/2021-March/643293.html
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
>
> This series enables support for the SPI NOR on the
> imx8mp based phyboard-pollux-rdk board.
>
> Patches new in v2:
> "spi: fspi: enable fspi driver for on imx8mp"
> which adds own compatible entry for imx8mp
>
> and seperate in own patch the documentation entry in
> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> as checkpatch says:
>
> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> Changes in v2:
> - work in comments from Marco
> add own compatible entry for imx8mp
> - work in comments from Marco
> - add own compatible entry "nxp,imx8mp-fspi"
> - reworked order of properties as Marco mentioned
> - work in comments from Marco and Teresa
> - rename node into "'som_flash: flash@0 { }"
> - compatible is now first entry
> - removed #size-cells and #address-cells
> as no child node. If bootloader adds them bootloader
> can add them too.
>
> Heiko Schocher (4):
> spi: fspi: enable fspi driver for on imx8mp
> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
> controller
> arm64: dts: imx8mp: add flexspi node
> arm64: imx8mp: imx8mp-phycore-som enable spi nor
Two DTS patch look good. Ping me when driver and bindings changes are
accepted.
Shawn
Hello Shawn,
On 15.03.21 07:47, Shawn Guo wrote:
> On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
>>
>> This series enables support for the SPI NOR on the
>> imx8mp based phyboard-pollux-rdk board.
>>
>> Patches new in v2:
>> "spi: fspi: enable fspi driver for on imx8mp"
>> which adds own compatible entry for imx8mp
>>
>> and seperate in own patch the documentation entry in
>> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
>> as checkpatch says:
>>
>> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>>
>>
>> Changes in v2:
>> - work in comments from Marco
>> add own compatible entry for imx8mp
>> - work in comments from Marco
>> - add own compatible entry "nxp,imx8mp-fspi"
>> - reworked order of properties as Marco mentioned
>> - work in comments from Marco and Teresa
>> - rename node into "'som_flash: flash@0 { }"
>> - compatible is now first entry
>> - removed #size-cells and #address-cells
>> as no child node. If bootloader adds them bootloader
>> can add them too.
>>
>> Heiko Schocher (4):
>> spi: fspi: enable fspi driver for on imx8mp
>> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
>> controller
>> arm64: dts: imx8mp: add flexspi node
>> arm64: imx8mp: imx8mp-phycore-som enable spi nor
>
> Two DTS patch look good. Ping me when driver and bindings changes are
> accepted.
Thanks!
Hmm.. I have not splitted this series into 2 series... should I do
this now?
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: [email protected]
On Mon, Mar 15, 2021 at 08:10:37AM +0100, Heiko Schocher wrote:
> Hello Shawn,
>
> On 15.03.21 07:47, Shawn Guo wrote:
> > On Tue, Mar 09, 2021 at 06:31:12AM +0100, Heiko Schocher wrote:
> >>
> >> This series enables support for the SPI NOR on the
> >> imx8mp based phyboard-pollux-rdk board.
> >>
> >> Patches new in v2:
> >> "spi: fspi: enable fspi driver for on imx8mp"
> >> which adds own compatible entry for imx8mp
> >>
> >> and seperate in own patch the documentation entry in
> >> patch "dt-bindings: spi: add compatible entry for imx8mp in FlexSPI controller"
> >> as checkpatch says:
> >>
> >> warning: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
> >>
> >>
> >> Changes in v2:
> >> - work in comments from Marco
> >> add own compatible entry for imx8mp
> >> - work in comments from Marco
> >> - add own compatible entry "nxp,imx8mp-fspi"
> >> - reworked order of properties as Marco mentioned
> >> - work in comments from Marco and Teresa
> >> - rename node into "'som_flash: flash@0 { }"
> >> - compatible is now first entry
> >> - removed #size-cells and #address-cells
> >> as no child node. If bootloader adds them bootloader
> >> can add them too.
> >>
> >> Heiko Schocher (4):
> >> spi: fspi: enable fspi driver for on imx8mp
> >> dt-bindings: spi: add compatible entry for imx8mp in FlexSPI
> >> controller
> >> arm64: dts: imx8mp: add flexspi node
> >> arm64: imx8mp: imx8mp-phycore-som enable spi nor
> >
> > Two DTS patch look good. Ping me when driver and bindings changes are
> > accepted.
>
> Thanks!
>
> Hmm.. I have not splitted this series into 2 series... should I do
> this now?
No, you do not need to. I sent the message only because I didn't
receive patch #1 and #2, so I will not be aware of their status.
Shawn
On Tue, Mar 09, 2021 at 06:31:15AM +0100, Heiko Schocher wrote:
> add node for the flexspi modul on imx8mp.
>
> Signed-off-by: Heiko Schocher <[email protected]>
Applied #3 and #4, thanks.