2008-03-26 20:36:22

by Ben Castricum

Subject: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo

Show a bit more info when updating microcode. It used to be there but
no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

Signed-off-by: Ben Castricum <[email protected]>

diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index f2702d0..ca1fd52 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -336,11 +336,11 @@ static void apply_microcode(int cpu)

spin_unlock_irqrestore(&microcode_update_lock, flags);
if (val[1] != uci->mc->hdr.rev) {
- printk(KERN_ERR "microcode: CPU%d updated from revision "
+ printk(KERN_ERR "microcode: CPU%d update from revision "
"0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
return;
}
- pr_debug("microcode: CPU%d updated from revision "
+ printk(KERN_INFO "microcode: CPU%d updated from revision "
"0x%x to 0x%x, date = %08x \n",
cpu_num, uci->rev, val[1], uci->mc->hdr.date);
uci->rev = val[1];

2008-03-26 20:41:25

by Randy Dunlap

Subject: Re: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo

On Wed, 26 Mar 2008 21:22:25 +0100 Ben Castricum wrote:

> Show a bit more info when updating microcode. It used to be there but
> no with DEBUG unset makes it very silent.
>
> This is my first patch, please let me know if I did anything wrong.
>
> Signed-off-by: Ben Castricum <[email protected]>
>
> diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
> index f2702d0..ca1fd52 100644
> --- a/arch/x86/kernel/microcode.c
> +++ b/arch/x86/kernel/microcode.c
> @@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
>
> spin_unlock_irqrestore(&microcode_update_lock, flags);
> if (val[1] != uci->mc->hdr.rev) {
> - printk(KERN_ERR "microcode: CPU%d updated from revision "
> + printk(KERN_ERR "microcode: CPU%d update from revision "
> "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
> return;
> }
> - pr_debug("microcode: CPU%d updated from revision "
> + printk(KERN_INFO "microcode: CPU%d updated from revision "
> "0x%x to 0x%x, date = %08x \n",
> cpu_num, uci->rev, val[1], uci->mc->hdr.date);
> uci->rev = val[1];

Your mailer client (*cough*) converted tabs to spaces,
so the patch does not apply cleanly now.
You'll need to find a way to send patches that does not mangle
whitespace.


---
~Randy

2008-03-26 21:04:32

by Jesper Juhl

Subject: Re: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo

On 26/03/2008, Randy Dunlap <[email protected]> wrote:
> On Wed, 26 Mar 2008 21:22:25 +0100 Ben Castricum wrote:
>
> > Show a bit more info when updating microcode. It used to be there but
> > no with DEBUG unset makes it very silent.
> >
> > This is my first patch, please let me know if I did anything wrong.
> >
> > Signed-off-by: Ben Castricum <[email protected]>

A line with "---" after Signed-off-by: is prefered.

A diffstat is also common.

To quote Documentation/SubmittingPatches :
"The canonical patch message body contains the following:

- A "from" line specifying the patch author.

- An empty line.

- The body of the explanation, which will be copied to the
permanent changelog to describe this patch.

- The "Signed-off-by:" lines, described above, which will
also go in the changelog.

- A marker line containing simply "---".

- Any additional comments not suitable for the changelog.

- The actual patch (diff output).
"

> >
> > diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
> > index f2702d0..ca1fd52 100644
> > --- a/arch/x86/kernel/microcode.c
> > +++ b/arch/x86/kernel/microcode.c
> > @@ -336,11 +336,11 @@ static void apply_microcode(int cpu)
> >
> > spin_unlock_irqrestore(&microcode_update_lock, flags);
> > if (val[1] != uci->mc->hdr.rev) {
> > - printk(KERN_ERR "microcode: CPU%d updated from revision "
> > + printk(KERN_ERR "microcode: CPU%d update from revision "
> > "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
> > return;
> > }
> > - pr_debug("microcode: CPU%d updated from revision "
> > + printk(KERN_INFO "microcode: CPU%d updated from revision "
> > "0x%x to 0x%x, date = %08x \n",
> > cpu_num, uci->rev, val[1], uci->mc->hdr.date);
> > uci->rev = val[1];
>
>
> Your mailer client (*cough*) converted tabs to spaces,
> so the patch does not apply cleanly now.
> You'll need to find a way to send patches that does not mangle
> whitespace.
>

Also, since this is a rather trivial patch (even hinted at in the
subject) you should probably have added [email protected] to Cc: - if
you don't, the chances that I will notice it and pick it up in the
trivial tree are pretty slim.

--
Jesper Juhl <[email protected]>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html

2008-03-26 21:50:32

by Ingo Molnar

Subject: Re: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo

* Ben Castricum <[email protected]> wrote:

> Show a bit more info when updating microcode. It used to be there but
> no with DEBUG unset makes it very silent.
>
> This is my first patch, please let me know if I did anything wrong.

your patch looks good to me, but there's some whitespace damage: all
your tabs in that patch got converted to spaces. Check out
Documentation/email-clients.txt and please resend it so that i can apply
it to x86.git.

Ingo