2022-02-15 23:21:41

by Sandeep Maheswaram

Subject: [PATCH 0/3] Add QCOM SNPS PHY overriding params support

Added support for overriding tuning parameters in QCOM SNPS PHY
from device tree.

Sandeep Maheswaram (3):
dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params
bindings
phy: qcom-snps: Add support for overriding phy tuning parameters
arm64: dts: qcom: sc7280: Update SNPS Phy params for SC7280 IDP device

.../bindings/phy/qcom,usb-snps-femto-v2.yaml | 16 ++++++++
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 4 ++
drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 45 ++++++++++++++++++++++
3 files changed, 65 insertions(+)

--
2.7.4

2022-02-16 04:17:35

by Sandeep Maheswaram

Subject: [PATCH 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings

Add support for overriding SNPS phy tuning parameters in device tree
bindings.

Signed-off-by: Sandeep Maheswaram <[email protected]>
---
.../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
index 0dfe691..44cf3bf 100644
--- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
@@ -50,6 +50,22 @@ properties:
vdda33-supply:
description: phandle to the regulator 3.3V supply node.

+ qcom,override_x0:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs disconnect and squelch detector threshold.
+
+ qcom,override_x1:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs amplitude, pre-emphasis duration and amplitude.
+
+ qcom,override_x2:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for hs rise/fall time, cross over voltage, output impedance.
+
+ qcom,override_x3:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description: Override value for ls/fs output impedance.
+
required:
- compatible
- reg
--
2.7.4

2022-02-16 08:06:22

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings

On 15/02/2022 20:19, Sandeep Maheswaram wrote:
> Add support for overriding SNPS phy tuning parameters in device tree
> bindings.
>
> Signed-off-by: Sandeep Maheswaram <[email protected]>
> ---
> .../devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> index 0dfe691..44cf3bf 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml
> @@ -50,6 +50,22 @@ properties:
> vdda33-supply:
> description: phandle to the regulator 3.3V supply node.
>
> + qcom,override_x0:

Do not use underscore in properties, but hyphen. Just like everywhere in
bindings.

This does not look like description of hardware but hard-coding some
register values. Bindings should rather describe the actual hardware
parameters instead of values written into registers.

Plus what other reviewers pointed about usefulness.

Best regards,
Krzysztof