2021-10-12 13:35:50

by Thomas Gleixner

[permalink] [raw]

Subject: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations

---

All these handlers are regular device interrupt handlers, so they already
went through the proper entry code which handles this correctly.

Signed-off-by: Thomas Gleixner <[email protected]>
Cc: Juergen Gross <[email protected]>
Cc: Stefano Stabellini <[email protected]>
Cc: Boris Ostrovsky <[email protected]>
Cc: [email protected]
Cc: [email protected]
---
arch/x86/xen/smp.c | 4 ----
arch/x86/xen/smp_pv.c | 2 --
2 files changed, 6 deletions(-)

--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -268,20 +268,16 @@ void xen_send_IPI_allbutself(int vector)

static irqreturn_t xen_call_function_interrupt(int irq, void *dev_id)
{
- irq_enter();
generic_smp_call_function_interrupt();
inc_irq_stat(irq_call_count);
- irq_exit();

return IRQ_HANDLED;
}

static irqreturn_t xen_call_function_single_interrupt(int irq, void *dev_id)
{
- irq_enter();
generic_smp_call_function_single_interrupt();
inc_irq_stat(irq_call_count);
- irq_exit();

return IRQ_HANDLED;
}
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -458,10 +458,8 @@ static void xen_pv_stop_other_cpus(int w

static irqreturn_t xen_irq_work_interrupt(int irq, void *dev_id)
{
- irq_enter();
irq_work_run();
inc_irq_stat(apic_irq_work_irqs);
- irq_exit();

return IRQ_HANDLED;
}

2021-10-12 14:31:23

by Jürgen Groß

[permalink] [raw]

Subject: Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations

---

On 12.10.21 15:33, Thomas Gleixner wrote:
> All these handlers are regular device interrupt handlers, so they already
> went through the proper entry code which handles this correctly.
>
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Juergen Gross <[email protected]>
> Cc: Stefano Stabellini <[email protected]>
> Cc: Boris Ostrovsky <[email protected]>
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Juergen Gross <[email protected]>


Juergen

---

Attachments:

OpenPGP_0xB0DE9DD628BF132F.asc (3.06 kB)
OpenPGP public key OpenPGP_signature (505.00 B)
OpenPGP digital signature Download all attachments

2021-10-27 21:25:18

by Boris Ostrovsky

[permalink] [raw]

Subject: Re: [PATCH] x86/xen: Remove redundant irq_enter/exit() invocations

---

On 10/12/21 10:25 AM, Juergen Gross wrote:
> On 12.10.21 15:33, Thomas Gleixner wrote:
>> All these handlers are regular device interrupt handlers, so they already
>> went through the proper entry code which handles this correctly.
>>
>> Signed-off-by: Thomas Gleixner <[email protected]>
>> Cc: Juergen Gross <[email protected]>
>> Cc: Stefano Stabellini <[email protected]>
>> Cc: Boris Ostrovsky <[email protected]>
>> Cc: [email protected]
>> Cc: [email protected]
>
> Reviewed-by: Juergen Gross <[email protected]>
>


Applied to for-linus-5.16


-boris