2022-11-26 10:45:55

by Christophe JAILLET

Subject: [PATCH] thermal/core/power allocator: Remove a useless include

This file does not use rcu, so there is no point in including
<linux/rculist.h>.

Remove it.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/thermal/gov_power_allocator.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
index 2d1aeaba38a8..d5d4eae16771 100644
--- a/drivers/thermal/gov_power_allocator.c
+++ b/drivers/thermal/gov_power_allocator.c
@@ -8,7 +8,6 @@

#define pr_fmt(fmt) "Power allocator: " fmt

-#include <linux/rculist.h>
#include <linux/slab.h>
#include <linux/thermal.h>

--
2.34.1

2022-11-28 08:16:50

by Lukasz Luba

Subject: Re: [PATCH] thermal/core/power allocator: Remove a useless include

On 11/26/22 10:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
>
> Remove it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/thermal/gov_power_allocator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index 2d1aeaba38a8..d5d4eae16771 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -8,7 +8,6 @@
>
> #define pr_fmt(fmt) "Power allocator: " fmt
>
> -#include <linux/rculist.h>
> #include <linux/slab.h>
> #include <linux/thermal.h>
>

Good catch.

Reviewed-by: Lukasz Luba <[email protected]>

2022-12-04 17:26:25

by Daniel Lezcano

Subject: Re: [PATCH] thermal/core/power allocator: Remove a useless include

On 26/11/2022 11:42, Christophe JAILLET wrote:
> This file does not use rcu, so there is no point in including
> <linux/rculist.h>.
>
> Remove it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied, thanks

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog