2008-01-23 09:14:54

by Loïc Grenié

[permalink] [raw]
Subject: vmalloc_32 and SLAB incompatible in 2.6.23.9

Since GFP_DMA32 is not considered a valid flag, vmalloc_32 and
SLAB are incompatible in kernel 2.6.23.9 (and probably later ones).
It might be as simple as adding GFP_DMA32 everywhere where
GFP_DMA is used in mm/slab.c, but I don't dare do it. I personally
switched to SLUB.

Thanks,

Lo?c Greni?


2008-01-23 09:35:38

by Andi Kleen

[permalink] [raw]
Subject: Re: vmalloc_32 and SLAB incompatible in 2.6.23.9

"Lo?c Greni?" <[email protected]> writes:

> Since GFP_DMA32 is not considered a valid flag, vmalloc_32 and
> SLAB are incompatible in kernel 2.6.23.9 (and probably later ones).
> It might be as simple as adding GFP_DMA32 everywhere where
> GFP_DMA is used in mm/slab.c, but I don't dare do it. I personally
> switched to SLUB.

I don't think it would really work for slub either.

If you look at /proc/slabinfo you see that there are separate DMA
caches. That is because sl[abo]b all cache objects and if the
objects have different requirements (like GFP_DMA, GFP_DMA32, GFP_KERNEL)
they would need different caches. Otherwise you risk getting
later objects originally allocated with the wrong flags.

To make GFP_DMA32 work would require adding another set of DMA32
caches to all kmalloc caches etc or a separate one for each
custom kmem cache that you use that only gets _DMA32 objects.

Better just use __get_free_pages() directly.

-Andi

2008-01-23 10:04:19

by Loïc Grenié

[permalink] [raw]
Subject: Re: vmalloc_32 and SLAB incompatible in 2.6.23.9

23 Jan 2008 10:35:28 +0100, Andi Kleen <[email protected]>:
> "Lo?c Greni?" <[email protected]> writes:
>
> > Since GFP_DMA32 is not considered a valid flag, vmalloc_32 and
> > SLAB are incompatible in kernel 2.6.23.9 (and probably later ones).
> > It might be as simple as adding GFP_DMA32 everywhere where
> > GFP_DMA is used in mm/slab.c, but I don't dare do it. I personally
> > switched to SLUB.
>
> I don't think it would really work for slub either.
>
> If you look at /proc/slabinfo you see that there are separate DMA
> caches. That is because sl[abo]b all cache objects and if the
> objects have different requirements (like GFP_DMA, GFP_DMA32, GFP_KERNEL)
> they would need different caches. Otherwise you risk getting
> later objects originally allocated with the wrong flags.
>
> To make GFP_DMA32 work would require adding another set of DMA32
> caches to all kmalloc caches etc or a separate one for each
> custom kmem cache that you use that only gets _DMA32 objects.
>
> Better just use __get_free_pages() directly.

vmalloc_32 is using __vmalloc. I am much too ignorant to try and change
anything in mm/*.[ch]. If vmalloc_32 is incompatible with sl[aou]b, should'nt
it be either modified or removed ?

Thanks,

Lo?c Greni?

2008-01-23 10:09:57

by Andi Kleen

[permalink] [raw]
Subject: Re: vmalloc_32 and SLAB incompatible in 2.6.23.9

> vmalloc_32 is using __vmalloc. I am much too ignorant to try and change
> anything in mm/*.[ch]. If vmalloc_32 is incompatible with sl[aou]b, should'nt
> it be either modified or removed ?

vmalloc does not use sl[aou]b for the data pages. That is why it can
support GFP_DMA32 (or even GFP_DMA if you wanted)

-Andi