2018-01-25 19:35:34

by SF Markus Elfring

Subject: [PATCH 0/2] Input-da9063_onkey: Adjustments for da9063_onkey_probe()

From: Markus Elfring <[email protected]>
Date: Thu, 25 Jan 2018 20:30:40 +0100

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
Delete an error message for a failed memory allocation
Improve a size determination

drivers/input/misc/da9063_onkey.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

--
2.16.1

2018-01-25 19:36:58

by SF Markus Elfring

Subject: [PATCH 1/2] Input: da9063_onkey: Delete an error message for a failed memory allocation in da9063_onkey_probe()

From: Markus Elfring <[email protected]>
Date: Thu, 25 Jan 2018 20:22:57 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/misc/da9063_onkey.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index 3e9c353d82ef..acf592975bef 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -215,10 +215,8 @@ static int da9063_onkey_probe(struct platform_device *pdev)

onkey = devm_kzalloc(&pdev->dev, sizeof(struct da9063_onkey),
GFP_KERNEL);
- if (!onkey) {
- dev_err(&pdev->dev, "Failed to allocate memory.\n");
+ if (!onkey)
return -ENOMEM;
- }

onkey->config = match->data;
onkey->dev = &pdev->dev;
--
2.16.1

2018-01-25 19:38:01

by SF Markus Elfring

Subject: [PATCH 2/2] Input: da9063_onkey: Improve a size determination in da9063_onkey_probe()

From: Markus Elfring <[email protected]>
Date: Thu, 25 Jan 2018 20:24:47 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/input/misc/da9063_onkey.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index acf592975bef..310f9c408636 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -213,8 +213,7 @@ static int da9063_onkey_probe(struct platform_device *pdev)
if (!match)
return -ENXIO;

- onkey = devm_kzalloc(&pdev->dev, sizeof(struct da9063_onkey),
- GFP_KERNEL);
+ onkey = devm_kzalloc(&pdev->dev, sizeof(*onkey), GFP_KERNEL);
if (!onkey)
return -ENOMEM;

--
2.16.1