2017-11-24 09:50:41

by Daniel Borkmann

[permalink] [raw]
Subject: Re: [PATCH v7 3/5] bpf: add a bpf_override_function helper

On 11/22/2017 10:23 PM, Josef Bacik wrote:
> From: Josef Bacik <[email protected]>
>
> Error injection is sloppy and very ad-hoc. BPF could fill this niche
> perfectly with it's kprobe functionality. We could make sure errors are
> only triggered in specific call chains that we care about with very
> specific situations. Accomplish this with the bpf_override_funciton
> helper. This will modify the probe'd callers return value to the
> specified value and set the PC to an override function that simply
> returns, bypassing the originally probed function. This gives us a nice
> clean way to implement systematic error injection for all of our code
> paths.
>
> Acked-by: Alexei Starovoitov <[email protected]>
> Acked-by: Ingo Molnar <[email protected]>
> Signed-off-by: Josef Bacik <[email protected]>

Series looks good to me as well; BPF bits:

Acked-by: Daniel Borkmann <[email protected]>

From 1584803032929187182@xxx Wed Nov 22 21:25:49 +0000 2017
X-GM-THRID: 1584803032929187182
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread